Issue 722773002: Revert r1998, it breaks iOS builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722773002: Revert r1998, it breaks iOS builds (Closed)

Created:
6 years, 1 month ago by Nico

Modified:
6 years, 1 month ago

Reviewers:
M-A Ruel

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -63 lines)			Patch
M	pylib/gyp/mac_tool.py	View	1 chunk	+1 line, -15 lines	0 comments	Download
D	test/mac/gyptest-libtool-zero.py	View	1 chunk	+0 lines, -26 lines	0 comments	Download
D	test/mac/libtool-zero/mylib.c	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	test/mac/libtool-zero/test.gyp	View	1 chunk	+0 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

Nico

Committed patchset #1 (id:1) manually as r2001 (presubmit successful).

6 years, 1 month ago (2014-11-12 18:24:26 UTC) #2

scottmg

6 years, 1 month ago (2014-11-12 18:56:47 UTC) #4

Message was sent while issue was closed.

Could we make gyp-mac http://build.chromium.org/f/client/gyp/ build a little bit
of iOS to catch this?