Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 722753002: Fix transitions/cross-fade-background-image.html (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers, yosin_UTC9
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix transitions/cross-fade-background-image.html This test started failing after codereview.chromium.org/716963002. The change to transitions/cross-fade-border-image.html in the linked patch is similar. Since the tryservers don't have numbers in their paths we didn't notice this test needed updating. BUG=432566 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185231

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/transitions/cross-fade-background-image.html View 2 chunks +8 lines, -2 lines 0 comments Download
M LayoutTests/transitions/cross-fade-background-image-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-12 17:50:50 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-12 17:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722753002/20001
6 years, 1 month ago (2014-11-12 17:58:47 UTC) #5
Stephen White
LGTM2 FWIW. Thanks!
6 years, 1 month ago (2014-11-12 18:35:29 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 18:44:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185231

Powered by Google App Engine
This is Rietveld 408576698