Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Unified Diff: remoting/host/it2me/it2me_host.cc

Issue 722743003: Reporting of policy errors via host-offline-reason: part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased and reopened to try memory trybots. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/it2me/it2me_host.h ('k') | remoting/host/policy_hack/fake_policy_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/it2me/it2me_host.cc
diff --git a/remoting/host/it2me/it2me_host.cc b/remoting/host/it2me/it2me_host.cc
index afaaf07e61ecc58493791fa7c0dd985e0be9dd73..eb13e47fa9666b4cce59691af08b4417a26aa62d 100644
--- a/remoting/host/it2me/it2me_host.cc
+++ b/remoting/host/it2me/it2me_host.cc
@@ -67,7 +67,9 @@ void It2MeHost::Connect() {
host_context_->ui_task_runner()));
// Start monitoring configured policies.
- policy_watcher_->StartWatching(base::Bind(&It2MeHost::OnPolicyUpdate, this));
+ policy_watcher_->StartWatching(
+ base::Bind(&It2MeHost::OnPolicyUpdate, this),
+ base::Bind(&It2MeHost::OnPolicyError, this));
// Switch to the network thread to start the actual connection.
host_context_->network_task_runner()->PostTask(
@@ -339,6 +341,11 @@ void It2MeHost::OnPolicyUpdate(scoped_ptr<base::DictionaryValue> policies) {
}
}
+void It2MeHost::OnPolicyError() {
+ // TODO(lukasza): Report the policy error to the user. crbug.com/433009
+ NOTIMPLEMENTED();
+}
+
void It2MeHost::UpdateNatPolicy(bool nat_traversal_enabled) {
DCHECK(host_context_->network_task_runner()->BelongsToCurrentThread());
« no previous file with comments | « remoting/host/it2me/it2me_host.h ('k') | remoting/host/policy_hack/fake_policy_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698