chrome/browser/thumbnails/thumbnail_service_impl.cc - Issue 722723005: Move constants used by history component to history namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/thumbnail_service_impl.cc

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initial patchset Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/url_utils.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc ('k') | chrome/common/chrome_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/thumbnails/thumbnail_service_impl.cc

diff --git a/chrome/browser/thumbnails/thumbnail_service_impl.cc b/chrome/browser/thumbnails/thumbnail_service_impl.cc

index 8f572d39b14994962831bcaef78b10eaf32e672e..1a97a764382dcb39c50612555da13e43d0656404 100644

--- a/chrome/browser/thumbnails/thumbnail_service_impl.cc

+++ b/chrome/browser/thumbnails/thumbnail_service_impl.cc

@@ -7,7 +7,7 @@

#include "base/command_line.h"

#include "base/memory/ref_counted_memory.h"

#include "base/time/time.h"

-#include "chrome/browser/history/history_service.h"

+#include "chrome/browser/history/url_utils.h"

#include "chrome/browser/thumbnails/content_based_thumbnailing_algorithm.h"

#include "chrome/browser/thumbnails/simple_thumbnail_crop.h"

#include "chrome/browser/thumbnails/thumbnailing_context.h"

@@ -98,7 +98,7 @@ bool ThumbnailServiceImpl::ShouldAcquirePageThumbnail(const GURL& url) {

return false;

// Skip if the given URL is not appropriate for history.

- if (!HistoryService::CanAddURL(url))

+ if (!history::CanAddURL(url))

return false;

// Skip if the top sites list is full, and the URL is not known.

if (local_ptr->IsNonForcedFull() && !local_ptr->IsKnownURL(url))