Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/history/top_sites_impl.cc

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initial patchset Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/top_sites_impl.cc
diff --git a/chrome/browser/history/top_sites_impl.cc b/chrome/browser/history/top_sites_impl.cc
index ba422eeef1502295ed52669de5e4224b25502e9a..854c18f72b2c6e2a271bb98aacc0e5a8c9ee5f3c 100644
--- a/chrome/browser/history/top_sites_impl.cc
+++ b/chrome/browser/history/top_sites_impl.cc
@@ -151,7 +151,7 @@ bool TopSitesImpl::SetPageThumbnail(const GURL& url,
}
}
- if (!HistoryService::CanAddURL(url))
+ if (!CanAddURL(url))
return false; // It's not a real webpage.
scoped_refptr<base::RefCountedBytes> thumbnail_data;
@@ -190,7 +190,7 @@ bool TopSitesImpl::SetPageThumbnailToJPEGBytes(
}
}
- if (!HistoryService::CanAddURL(url))
+ if (!CanAddURL(url))
return false; // It's not a real webpage.
if (add_temp_thumbnail) {
@@ -777,7 +777,7 @@ void TopSitesImpl::Observe(int type,
if (!load_details)
return;
const GURL& url = load_details->entry->GetURL();
- if (!cache_->IsKnownURL(url) && HistoryService::CanAddURL(url)) {
+ if (!cache_->IsKnownURL(url) && CanAddURL(url)) {
// To avoid slamming history we throttle requests when the url updates.
// To do otherwise negatively impacts perf tests.
RestartQueryForTopSitesTimer(GetUpdateDelay());

Powered by Google App Engine
This is Rietveld 408576698