chrome/browser/history/history_service.h - Issue 722723005: Move constants used by history component to history namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.h

Issue 722723005: Move constants used by history component to history namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initial patchset Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | chrome/browser/history/url_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_service.h

diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h

index 91b4bfcda6e7ad0b2441207375ce6cca560cb8b2..3c75652d0279d8eeea4c8d34da51e1ebf4083d81 100644

--- a/chrome/browser/history/history_service.h

+++ b/chrome/browser/history/history_service.h

@@ -492,10 +492,6 @@ class HistoryService : public content::NotificationObserver,

void AddPagesWithDetails(const history::URLRows& info,

history::VisitSource visit_source);

- // Returns true if this looks like the type of URL we want to add to the

- // history. We filter out some URLs such as JavaScript.

- static bool CanAddURL(const GURL& url);

// Returns the HistoryClient.

history::HistoryClient* history_client() { return history_client_; }

« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.cc » ('j') | chrome/browser/history/url_utils.cc » ('J')