Move public symbols to the root set.

Move public symbols to the root set.

This allows serializing public symbols that are embedded in code.

BUG=v8:3689
LOG=N
R=rossberg@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/b96309b776e4d10b6d8eeea7b5951422ee732c19

[Yang, 2014-11-12 16:24:30]

yangguo@chromium.org changed reviewers:
+ rossberg@chromium.org

[Yang, 2014-11-12 16:24:31]

Please take a look.

[rossberg, 2014-11-12 16:45:25]

Looks good, I suppose, just some confusion on my side.

https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc
File src/ast-value-factory.cc (right):

https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc...
src/ast-value-factory.cc:185: DCHECK_EQ(0, strcmp(symbol_name_,
"iterator_symbol"));
Why can this only happen for the iterator symbol?

https://codereview.chromium.org/722723002/diff/20001/src/harmony-tostring.js
File src/harmony-tostring.js (left):

https://codereview.chromium.org/722723002/diff/20001/src/harmony-tostring.js#...
src/harmony-tostring.js:12: var symbolToStringTag =
InternalSymbol("Symbol.toStringTag");
Hm, I'm confused. Where is this variable defined now? Note that it is used
below.

[Yang, 2014-11-12 17:18:32]

https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc
File src/ast-value-factory.cc (right):

https://codereview.chromium.org/722723002/diff/20001/src/ast-value-factory.cc...
src/ast-value-factory.cc:185: DCHECK_EQ(0, strcmp(symbol_name_,
"iterator_symbol"));
On 2014/11/12 16:45:25, rossberg wrote:
> Why can this only happen for the iterator symbol?

right now this is only used for the iterator symbol. if we need other symbols
embedded in the future, we would have to multiplex.

https://codereview.chromium.org/722723002/diff/20001/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/722723002/diff/20001/src/bootstrapper.cc#newc...
src/bootstrapper.cc:1994: JSObject::AddProperty(builtins, varname,
factory()->name(), attributes);
This installs the public symbols on the builtins object.

https://codereview.chromium.org/722723002/diff/20001/src/harmony-tostring.js
File src/harmony-tostring.js (left):

https://codereview.chromium.org/722723002/diff/20001/src/harmony-tostring.js#...
src/harmony-tostring.js:12: var symbolToStringTag =
InternalSymbol("Symbol.toStringTag");
On 2014/11/12 16:45:25, rossberg wrote:
> Hm, I'm confused. Where is this variable defined now? Note that it is used
> below.

See bootstrapper.cc

[rossberg, 2014-11-12 17:25:54]

LGTM. Some of the stuff (for_intern field) in runtime-symbols.cc is probably
obsolete now, though.

[Yang, 2014-11-13 08:48:15]

Committed patchset #3 (id:40001) manually as
b96309b776e4d10b6d8eeea7b5951422ee732c19 (presubmit successful).