Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1686)

Unified Diff: mojo/services/view_manager/view_manager_service_impl.cc

Issue 722713003: Sky: Add a test for the <iframe> element (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/tests/lowlevel/iframe.sky » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/view_manager/view_manager_service_impl.cc
diff --git a/mojo/services/view_manager/view_manager_service_impl.cc b/mojo/services/view_manager/view_manager_service_impl.cc
index 323d2dbe4d232a67f70bf857da9c5a6b474353cb..c346b716a03ba7736490336e5ca26078689ac441 100644
--- a/mojo/services/view_manager/view_manager_service_impl.cc
+++ b/mojo/services/view_manager/view_manager_service_impl.cc
@@ -364,7 +364,10 @@ void ViewManagerServiceImpl::NotifyDrawnStateChanged(const ServerView* view,
return;
const ServerView* root = GetView(*root_);
- DCHECK(root);
+ // TODO(sky): Find out why this DCHECK gets hit when running
+ // sky/tools/skydb sky/tests/lowlevel/iframe.sky
+ // http://crbug.com/432658
+ // DCHECK(root);
if (view->Contains(root) &&
(new_drawn_value != root->IsDrawn(connection_manager_->root()))) {
client()->OnViewDrawnStateChanged(ViewIdToTransportId(root->id()),
« no previous file with comments | « no previous file | sky/tests/lowlevel/iframe.sky » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698