Issue 722713003: Sky: Add a test for the <iframe> element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722713003: Sky: Add a test for the <iframe> element (Closed)

Created:
6 years, 1 month ago by Matt Perry

Modified:
6 years, 1 month ago

Reviewers:
sky

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Sky: Add a test for the <iframe> element. Had to disable a DCHECK for now. Scott will investigate why the DCHECK is hit. BUG=432658 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a94dee5cdffcabc11f982af15c5be054cd255984

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
M	mojo/services/view_manager/view_manager_service_impl.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
A	sky/tests/lowlevel/iframe.sky	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	sky/tests/lowlevel/iframe-expected.txt	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	sky/viewer/document_view.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Matt Perry

6 years, 1 month ago (2014-11-12 21:50:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a94dee5cdffcabc11f982af15c5be054cd255984 (presubmit successful).