DevTools: get rid of getters and setters in StatusBarButton.

Source/devtools/front_end/ui/StatusBarButton.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 
 WebInspector.StatusBarItem.prototype = {
     /**
      * @param {boolean} value
      */
     setEnabled: function(value)
     {
         if (this._enabled === value)
             return;
         this._enabled = value;
-        this.applyEnabledState();
+        this._applyEnabledState();
     },
 
-    /**
-     * @protected
-     */
-    applyEnabledState: function()
+    _applyEnabledState: function()
     {
         this.element.disabled = !this._enabled;
     },
 
-    get visible()
+    /**
+     * @return {boolean} x
+     */
+    visible: function()
     {
         return this._visible;
     },
 
-    set visible(x)
+    /**
+     * @param {boolean} x
+     */
+    setVisible: function(x)
     {
         if (this._visible === x)
             return;
         this.element.classList.toggle("hidden", !x);
         this._visible = x;
     },
 
     __proto__: WebInspector.Object.prototype
 }
 
@@ skipping 159 matching lines @@
  */
 WebInspector.StatusBarButtonBase = function(title, className, states)
 {
     WebInspector.StatusBarItem.call(this, "button");
     this.element.className = className + " status-bar-item";
     this.element.addEventListener("click", this._clicked.bind(this), false);
     this._longClickController = new WebInspector.LongClickController(this.element);
     this._longClickController.addEventListener(WebInspector.LongClickController.Events.LongClick, this._onLongClick.bind(this));
     this._longClickController.addEventListener(WebInspector.LongClickController.Events.LongPress, this._onLongPress.bind(this));
 
-    this.states = states;
+    this._states = states;
     if (!states)
-        this.states = 2;
+        this._states = 2;
 
     if (states == 2)
-        this._state = false;
+        this._state = "off";
     else
-        this._state = 0;
+        this._state = "0";
 
     this.title = title;
     this.className = className;
 }
 
 WebInspector.StatusBarButtonBase.prototype = {
     /**
      * @param {!WebInspector.Event} event
      */
     _onLongClick: function(event)
@@ skipping 11 matching lines @@
 
     _clicked: function()
     {
         this.dispatchEventToListeners("click");
         this._longClickController.reset();
     },
 
     /**
      * @override
      */
-    applyEnabledState: function()
+    _applyEnabledState: function()
     {
         this.element.disabled = !this._enabled;
         this._longClickController.reset();
     },
 
     /**
      * @return {boolean}
      */
     enabled: function()
     {
         return this._enabled;
     },
 
-    get title()
-    {
-        return this._title;
-    },
-
-    set title(x)
+    /**
+     * @param {string} x
+     */
+    setTitle: function(x)
     {
         if (this._title === x)
             return;
         this._title = x;
         this.element.title = x;
     },
 
-    get state()
+    /**
+     * @return {string}
+     */
+    state: function()
     {
         return this._state;
     },
 
-    set state(x)
+    /**
+     * @param {string} x
+     */
+    setState: function(x)
     {
         if (this._state === x)
             return;
 
-        if (this.states === 2) {
-            this.element.classList.toggle("toggled-on", x);
-        } else {
-            this.element.classList.remove("toggled-" + this._state);
-            if (x !== 0)
-                this.element.classList.add("toggled-" + x);
-        }
+        this.element.classList.remove("toggled-" + this._state);
+        this.element.classList.add("toggled-" + x);
         this._state = x;
     },
 
-    get toggled()
+    /**
+     * @return {boolean}
+     */
+    toggled: function()
     {
-        if (this.states !== 2)
+        if (this._states !== 2)
             throw("Only used toggled when there are 2 states, otherwise, use state");
-        return this.state;
+        return this.state() === "on";
     },
 
-    set toggled(x)
+    /**
+     * @param {boolean} x
+     */
+    setToggled: function(x)
     {
-        if (this.states !== 2)
+        if (this._states !== 2)
             throw("Only used toggled when there are 2 states, otherwise, use state");
-        this.state = x;
+        this.setState(x ? "on" : "off");
     },
 
     makeLongClickEnabled: function()
     {
         this._longClickController.enable();
     },
 
     unmakeLongClickEnabled: function()
     {
         this._longClickController.disable();
@@ skipping 30 matching lines @@
             this.removeEventListener("longClickDown", this._longClickOptionsData.longClickDownListener, this);
             delete this._longClickOptionsData;
 
             this.unmakeLongClickEnabled();
         }
     },
 
     _showOptions: function()
     {
         var buttons = this._longClickOptionsData.buttonsProvider();
-        var mainButtonClone = new WebInspector.StatusBarButton(this.title, this.className, this.states);
+        var mainButtonClone = new WebInspector.StatusBarButton(this.title, this.className, this._states);
         mainButtonClone.addEventListener("click", this._clicked, this);
-        mainButtonClone.state = this.state;
+        mainButtonClone.setState(this.state());
         buttons.push(mainButtonClone);
 
         var document = this.element.ownerDocument;
         document.documentElement.addEventListener("mouseup", mouseUp, false);
 
         var optionsGlassPane = new WebInspector.GlassPane(document);
         var optionsBarElement = optionsGlassPane.element.createChild("div", "alternate-status-bar-buttons-bar");
         const buttonHeight = 23;
 
         var hostButtonPosition = this.element.totalOffset();
@@ skipping 163 matching lines @@
         if (title)
             option.title = title;
         if (typeof value !== "undefined")
             option.value = value;
         return option;
     },
 
     /**
      * @override
      */
-    applyEnabledState: function()
+    _applyEnabledState: function()
     {
         this._selectElement.disabled = !this._enabled;
     },
 
     /**
      * @param {!Element} option
      */
     removeOption: function(option)
     {
         this._selectElement.removeChild(option);
@@ skipping 82 matching lines @@
 {
     WebInspector.StatusBarButton.call(this, "", className, states.length);
 
     var onClickBound = this._onClick.bind(this);
     this.addEventListener("click", onClickBound, this);
 
     this._states = states;
     this._buttons = [];
     for (var index = 0; index < states.length; index++) {
         var button = new WebInspector.StatusBarButton(titles[index], className, states.length);
-        button.state = this._states[index];
+        button.setState(this._states[index]);
         button.addEventListener("click", onClickBound, this);
         this._buttons.push(button);
     }
 
     this._currentStateSetting = currentStateSetting;
     this._lastStateSetting = lastStateSetting;
     this._stateChangedCallback = stateChangedCallback;
     this.setLongClickOptionsEnabled(this._createOptions.bind(this));
 
     this._currentState = null;
     this.toggleState(initialState);
 }
 
 WebInspector.StatusBarStatesSettingButton.prototype = {
     /**
      * @param {!WebInspector.Event} e
      */
     _onClick: function(e)
     {
-        this.toggleState(e.target.state);
+        this.toggleState(e.target.state());
     },
 
     /**
      * @param {string} state
      */
     toggleState: function(state)
     {
         if (this._currentState === state)
             return;
 
         if (this._currentState)
             this._lastStateSetting.set(this._currentState);
         this._currentState = state;
         this._currentStateSetting.set(this._currentState);
 
         if (this._stateChangedCallback)
             this._stateChangedCallback(state);
 
         var defaultState = this._defaultState();
-        this.state = defaultState;
+        this.setState(defaultState);
         this.title = this._buttons[this._states.indexOf(defaultState)].title;
     },
 
     /**
      * @return {string}
      */
     _defaultState: function()
     {
         var lastState = this._lastStateSetting.get();
         if (lastState && this._states.indexOf(lastState) >= 0 && lastState != this._currentState)
             return lastState;
         if (this._states.length > 1 && this._currentState === this._states[0])
             return this._states[1];
         return this._states[0];
     },
 
     /**
      * @return {!Array.<!WebInspector.StatusBarButton>}
      */
     _createOptions: function()
     {
         var options = [];
         for (var index = 0; index < this._states.length; index++) {
-            if (this._states[index] !== this.state && this._states[index] !== this._currentState)
+            if (this._states[index] !== this.state() && this._states[index] !== this._currentState)
                 options.push(this._buttons[index]);
         }
         return options;
     },
 
     __proto__: WebInspector.StatusBarButton.prototype
 }