Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: Source/devtools/front_end/toolbox/ResponsiveDesignView.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @implements {WebInspector.OverridesSupport.PageResizer} 8 * @implements {WebInspector.OverridesSupport.PageResizer}
9 * @implements {WebInspector.TargetManager.Observer} 9 * @implements {WebInspector.TargetManager.Observer}
10 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder 10 * @param {!WebInspector.InspectedPagePlaceholder} inspectedPagePlaceholder
(...skipping 477 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 488
489 var canvasInvalidated = viewportChanged || this._drawContentsSize !== th is._cachedDrawContentsSize || this._cachedScale !== this._scale || 489 var canvasInvalidated = viewportChanged || this._drawContentsSize !== th is._cachedDrawContentsSize || this._cachedScale !== this._scale ||
490 this._cachedCssCanvasWidth !== cssCanvasWidth || this._cachedCssCanv asHeight !== cssCanvasHeight || this._cachedZoomFactor !== zoomFactor || 490 this._cachedCssCanvasWidth !== cssCanvasWidth || this._cachedCssCanv asHeight !== cssCanvasHeight || this._cachedZoomFactor !== zoomFactor ||
491 this._cachedMediaInspectorHeight !== mediaInspectorHeight; 491 this._cachedMediaInspectorHeight !== mediaInspectorHeight;
492 492
493 if (canvasInvalidated) 493 if (canvasInvalidated)
494 this._drawCanvas(cssCanvasWidth, cssCanvasHeight, rulerTotalHeight); 494 this._drawCanvas(cssCanvasWidth, cssCanvasHeight, rulerTotalHeight);
495 495
496 if (viewportChanged) { 496 if (viewportChanged) {
497 this._pageScaleLabel.textContent = WebInspector.UIString("%.1f", thi s._viewport.pageScaleFactor); 497 this._pageScaleLabel.textContent = WebInspector.UIString("%.1f", thi s._viewport.pageScaleFactor);
498 this._decreasePageScaleButton.title = WebInspector.UIString("Scale d own (minimum %.1f)", this._viewport.minimumPageScaleFactor); 498 this._decreasePageScaleButton.setTitle(WebInspector.UIString("Scale down (minimum %.1f)", this._viewport.minimumPageScaleFactor));
499 this._decreasePageScaleButton.setEnabled(this._viewport.pageScaleFac tor > this._viewport.minimumPageScaleFactor); 499 this._decreasePageScaleButton.setEnabled(this._viewport.pageScaleFac tor > this._viewport.minimumPageScaleFactor);
500 this._increasePageScaleButton.title = WebInspector.UIString("Scale u p (maximum %.1f)", this._viewport.maximumPageScaleFactor); 500 this._increasePageScaleButton.setTitle(WebInspector.UIString("Scale up (maximum %.1f)", this._viewport.maximumPageScaleFactor));
501 this._increasePageScaleButton.setEnabled(this._viewport.pageScaleFac tor < this._viewport.maximumPageScaleFactor); 501 this._increasePageScaleButton.setEnabled(this._viewport.pageScaleFac tor < this._viewport.maximumPageScaleFactor);
502 } 502 }
503 503
504 this._cachedScale = this._scale; 504 this._cachedScale = this._scale;
505 this._cachedCssCanvasWidth = cssCanvasWidth; 505 this._cachedCssCanvasWidth = cssCanvasWidth;
506 this._cachedCssCanvasHeight = cssCanvasHeight; 506 this._cachedCssCanvasHeight = cssCanvasHeight;
507 this._cachedCssHeight = cssHeight; 507 this._cachedCssHeight = cssHeight;
508 this._cachedCssWidth = cssWidth; 508 this._cachedCssWidth = cssWidth;
509 this._cachedZoomFactor = zoomFactor; 509 this._cachedZoomFactor = zoomFactor;
510 this._cachedViewport = this._viewport; 510 this._cachedViewport = this._viewport;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
553 _createButtonsSection: function() 553 _createButtonsSection: function()
554 { 554 {
555 var buttonsSection = this._toolbarElement.createChild("div", "responsive -design-section responsive-design-section-buttons"); 555 var buttonsSection = this._toolbarElement.createChild("div", "responsive -design-section responsive-design-section-buttons");
556 556
557 var resetButton = new WebInspector.StatusBarButton(WebInspector.UIString ("Reset all overrides."), "clear-status-bar-item"); 557 var resetButton = new WebInspector.StatusBarButton(WebInspector.UIString ("Reset all overrides."), "clear-status-bar-item");
558 buttonsSection.appendChild(resetButton.element); 558 buttonsSection.appendChild(resetButton.element);
559 resetButton.addEventListener("click", WebInspector.overridesSupport.rese t, WebInspector.overridesSupport); 559 resetButton.addEventListener("click", WebInspector.overridesSupport.rese t, WebInspector.overridesSupport);
560 560
561 // Media Query Inspector. 561 // Media Query Inspector.
562 this._toggleMediaInspectorButton = new WebInspector.StatusBarButton(WebI nspector.UIString("Media queries not found"), "responsive-design-toggle-media-in spector"); 562 this._toggleMediaInspectorButton = new WebInspector.StatusBarButton(WebI nspector.UIString("Media queries not found"), "responsive-design-toggle-media-in spector");
563 this._toggleMediaInspectorButton.toggled = WebInspector.settings.showMed iaQueryInspector.get(); 563 this._toggleMediaInspectorButton.setToggled(WebInspector.settings.showMe diaQueryInspector.get());
564 this._toggleMediaInspectorButton.setEnabled(false); 564 this._toggleMediaInspectorButton.setEnabled(false);
565 this._toggleMediaInspectorButton.addEventListener("click", this._onToggl eMediaInspectorButtonClick, this); 565 this._toggleMediaInspectorButton.addEventListener("click", this._onToggl eMediaInspectorButtonClick, this);
566 WebInspector.settings.showMediaQueryInspector.addChangeListener(this._up dateMediaQueryInspector, this); 566 WebInspector.settings.showMediaQueryInspector.addChangeListener(this._up dateMediaQueryInspector, this);
567 buttonsSection.appendChild(this._toggleMediaInspectorButton.element); 567 buttonsSection.appendChild(this._toggleMediaInspectorButton.element);
568 }, 568 },
569 569
570 _createDeviceSection: function() 570 _createDeviceSection: function()
571 { 571 {
572 var deviceSection = this._toolbarElement.createChild("div", "responsive- design-section responsive-design-section-device"); 572 var deviceSection = this._toolbarElement.createChild("div", "responsive- design-section responsive-design-section-device");
573 573
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
638 fieldsetElement.appendChild(WebInspector.OverridesUI.createNetworkCondit ionsSelect()); 638 fieldsetElement.appendChild(WebInspector.OverridesUI.createNetworkCondit ionsSelect());
639 639
640 // User agent. 640 // User agent.
641 var userAgentElement = networkSection.createChild("div", "responsive-des ign-suite").createChild("div"); 641 var userAgentElement = networkSection.createChild("div", "responsive-des ign-suite").createChild("div");
642 fieldsetElement = userAgentElement.createChild("fieldset"); 642 fieldsetElement = userAgentElement.createChild("fieldset");
643 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("UA", WebInspector.overridesSupport.settings.userAgent, false, 0, "", undefi ned, false, false, WebInspector.UIString("No override"))); 643 fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingInputFi eld("UA", WebInspector.overridesSupport.settings.userAgent, false, 0, "", undefi ned, false, false, WebInspector.UIString("No override")));
644 }, 644 },
645 645
646 _onToggleMediaInspectorButtonClick: function() 646 _onToggleMediaInspectorButtonClick: function()
647 { 647 {
648 WebInspector.settings.showMediaQueryInspector.set(!this._toggleMediaInsp ectorButton.toggled); 648 WebInspector.settings.showMediaQueryInspector.set(!this._toggleMediaInsp ectorButton.toggled());
649 }, 649 },
650 650
651 _updateMediaQueryInspector: function() 651 _updateMediaQueryInspector: function()
652 { 652 {
653 this._toggleMediaInspectorButton.toggled = WebInspector.settings.showMed iaQueryInspector.get(); 653 this._toggleMediaInspectorButton.setToggled(WebInspector.settings.showMe diaQueryInspector.get());
654 if (this._mediaInspector.isShowing() === WebInspector.settings.showMedia QueryInspector.get()) 654 if (this._mediaInspector.isShowing() === WebInspector.settings.showMedia QueryInspector.get())
655 return; 655 return;
656 if (this._mediaInspector.isShowing()) 656 if (this._mediaInspector.isShowing())
657 this._mediaInspector.detach(); 657 this._mediaInspector.detach();
658 else 658 else
659 this._mediaInspector.show(this._mediaInspectorContainer); 659 this._mediaInspector.show(this._mediaInspectorContainer);
660 this.onResize(); 660 this.onResize();
661 }, 661 },
662 662
663 /** 663 /**
664 * @param {!WebInspector.Event} event 664 * @param {!WebInspector.Event} event
665 */ 665 */
666 _updateMediaQueryInspectorButton: function(event) 666 _updateMediaQueryInspectorButton: function(event)
667 { 667 {
668 var count = /** @type {number} */ (event.data); 668 var count = /** @type {number} */ (event.data);
669 this._toggleMediaInspectorButton.setEnabled(!!count); 669 this._toggleMediaInspectorButton.setEnabled(!!count);
670 this._toggleMediaInspectorButton.title = !count ? WebInspector.UIString( "Media queries not found") : 670 this._toggleMediaInspectorButton.setTitle(!count ? WebInspector.UIString ("Media queries not found") :
671 WebInspector.UIString((count === 1 ? "%d media query found" : "%d me dia queries found"), count); 671 WebInspector.UIString((count === 1 ? "%d media query found" : "%d me dia queries found"), count));
672 }, 672 },
673 673
674 _overridesWarningUpdated: function() 674 _overridesWarningUpdated: function()
675 { 675 {
676 var message = WebInspector.settings.disableOverridesWarning.get() ? "" : WebInspector.overridesSupport.warningMessage(); 676 var message = WebInspector.settings.disableOverridesWarning.get() ? "" : WebInspector.overridesSupport.warningMessage();
677 if (this._warning === message) 677 if (this._warning === message)
678 return; 678 return;
679 this._warning = message; 679 this._warning = message;
680 this._warningMessage.classList.toggle("hidden", !message); 680 this._warningMessage.classList.toggle("hidden", !message);
681 this._warningMessage.querySelector("span").textContent = message; 681 this._warningMessage.querySelector("span").textContent = message;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 function updatePageScaleFactor(finishCallback) 754 function updatePageScaleFactor(finishCallback)
755 { 755 {
756 if (this._target && this._viewport && this._viewport.minimumPageScal eFactor <= 1 && this._viewport.maximumPageScaleFactor >= 1) 756 if (this._target && this._viewport && this._viewport.minimumPageScal eFactor <= 1 && this._viewport.maximumPageScaleFactor >= 1)
757 this._target.pageAgent().setPageScaleFactor(1); 757 this._target.pageAgent().setPageScaleFactor(1);
758 finishCallback(); 758 finishCallback();
759 } 759 }
760 }, 760 },
761 761
762 __proto__: WebInspector.VBox.prototype 762 __proto__: WebInspector.VBox.prototype
763 }; 763 };
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TransformController.js ('k') | Source/devtools/front_end/ui/FilterBar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698