DevTools: get rid of getters and setters in StatusBarButton.

Source/devtools/front_end/timeline/TimelinePanel.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 306 matching lines @@
 
         this._filterBar = this._createFilterBar();
         panelStatusBarElement.appendChild(this._filterBar.filterButton().element);
 
         var garbageCollectButton = new WebInspector.StatusBarButton(WebInspector.UIString("Collect garbage"), "timeline-garbage-collect-status-bar-item");
         garbageCollectButton.addEventListener("click", this._garbageCollectButtonClicked, this);
         this._statusBarButtons.push(garbageCollectButton);
         panelStatusBarElement.appendChild(garbageCollectButton.element);
 
         var framesToggleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Frames view. (Activity split into frames)"), "timeline-frames-status-bar-item");
-        framesToggleButton.toggled = this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames;
+        framesToggleButton.setToggled(this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames);
         framesToggleButton.addEventListener("click", this._overviewModeChanged.bind(this, framesToggleButton));
         this._statusBarButtons.push(framesToggleButton);
         panelStatusBarElement.appendChild(framesToggleButton.element);
 
         this._flameChartToggleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Flame chart view. (Use WASD or time selection to navigate)"), "timeline-flame-chart-status-bar-item");
-        this._flameChartToggleButton.toggled = this._flameChartEnabledSetting.get();
+        this._flameChartToggleButton.setToggled(this._flameChartEnabledSetting.get());
         this._flameChartToggleButton.addEventListener("click", this._flameChartEnabledChanged.bind(this));
         this._statusBarButtons.push(this._flameChartToggleButton);
         panelStatusBarElement.appendChild(this._flameChartToggleButton.element);
 
         this._captureCausesSetting = WebInspector.settings.createSetting("timelineCaptureCauses", true);
         this._captureCausesSetting.addChangeListener(this._refreshViews, this);
         panelStatusBarElement.appendChild(this._createSettingCheckbox(WebInspector.UIString("Causes"),
                                                                       this._captureCausesSetting,
                                                                       WebInspector.UIString("Capture causes (e.g., stack traces) for timeline events. (Has performance overhead)")));
         if (Runtime.experiments.isEnabled("timelineJSCPUProfile")) {
@@ skipping 205 matching lines @@
     },
 
     /**
      * @param {!WebInspector.StatusBarButton} button
      */
     _overviewModeChanged: function(button)
     {
         var oldMode = this._overviewModeSetting.get();
         if (oldMode === WebInspector.TimelinePanel.OverviewMode.Events) {
             this._overviewModeSetting.set(WebInspector.TimelinePanel.OverviewMode.Frames);
-            button.toggled = true;
+            button.setToggled(true);
         } else {
             this._overviewModeSetting.set(WebInspector.TimelinePanel.OverviewMode.Events);
-            button.toggled = false;
+            button.setToggled(false);
         }
         this._onModeChanged();
     },
 
     _flameChartEnabledChanged: function()
     {
         var oldValue = this._flameChartEnabledSetting.get();
         var newValue = !oldValue;
         this._flameChartEnabledSetting.set(newValue);
-        this._flameChartToggleButton.toggled = newValue;
+        this._flameChartToggleButton.setToggled(newValue);
         this._onModeChanged();
     },
 
     _onModeChanged: function()
     {
         this._stackView.detach();
 
         var isFrameMode = this._overviewModeSetting.get() === WebInspector.TimelinePanel.OverviewMode.Frames;
         this._removeAllModeViews();
         this._overviewControls = [];
@@ skipping 77 matching lines @@
         if (this._progressElement)
             this._updateProgress(WebInspector.UIString("Retrieving events\u2026"));
 
         for (var i = 0; i < this._overviewControls.length; ++i)
             this._overviewControls[i].timelineStopped();
         this._setUIControlsEnabled(true);
     },
 
     _onSuspendStateChanged: function()
     {
-        this._updateToggleTimelineButton(this.toggleTimelineButton.toggled);
+        this._updateToggleTimelineButton(this.toggleTimelineButton.toggled());
     },
 
     /**
      * @param {boolean} toggled
      */
     _updateToggleTimelineButton: function(toggled)
     {
-        this.toggleTimelineButton.toggled = toggled;
+        this.toggleTimelineButton.setToggled(toggled);
         if (toggled) {
-            this.toggleTimelineButton.title = WebInspector.UIString("Stop");
+            this.toggleTimelineButton.setTitle(WebInspector.UIString("Stop"));
             this.toggleTimelineButton.setEnabled(true);
         } else if (this._stopPending) {
-            this.toggleTimelineButton.title = WebInspector.UIString("Stop pending");
+            this.toggleTimelineButton.setTitle(WebInspector.UIString("Stop pending"));
             this.toggleTimelineButton.setEnabled(false);
         } else if (WebInspector.targetManager.allTargetsSuspended()) {
-            this.toggleTimelineButton.title = WebInspector.anotherProfilerActiveLabel();
+            this.toggleTimelineButton.setTitle(WebInspector.anotherProfilerActiveLabel());
             this.toggleTimelineButton.setEnabled(false);
         } else {
-            this.toggleTimelineButton.title = WebInspector.UIString("Record");
+            this.toggleTimelineButton.setTitle(WebInspector.UIString("Record"));
             this.toggleTimelineButton.setEnabled(true);
         }
     },
 
     /**
      * @return {boolean}
      */
     _toggleTimelineButtonClicked: function()
     {
         if (!this.toggleTimelineButton.enabled())
@@ skipping 41 matching lines @@
     {
         this._updateToggleTimelineButton(true);
         if (event.data && event.data.fromFile)
             this._updateProgress(WebInspector.UIString("Loading from file..."));
         else
             this._updateProgress(WebInspector.UIString("%d events collected", 0));
     },
 
     _recordingInProgress: function()
     {
-        return this.toggleTimelineButton.toggled;
+        return this.toggleTimelineButton.toggled();
     },
 
     /**
      * @param {!WebInspector.Event} event
      */
     _onTracingBufferUsage: function(event)
     {
         var usage = /** @type {number} */ (event.data);
         this._updateProgress(WebInspector.UIString("Buffer usage %d%", Math.round(usage * 100)));
     },
@@ skipping 706 matching lines @@
 
 WebInspector.TimelinePanelFactory.prototype = {
     /**
      * @return {!WebInspector.Panel}
      */
     createPanel: function()
     {
         return WebInspector.TimelinePanel._instance();
     }
 }