Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 722713002: DevTools: get rid of getters and setters in StatusBarButton. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 this._perspectives.push(new WebInspector.HeapSnapshotView.AllocationPers pective()); 137 this._perspectives.push(new WebInspector.HeapSnapshotView.AllocationPers pective());
138 this._perspectives.push(new WebInspector.HeapSnapshotView.StatisticsPerspect ive()); 138 this._perspectives.push(new WebInspector.HeapSnapshotView.StatisticsPerspect ive());
139 139
140 this._perspectiveSelect = new WebInspector.StatusBarComboBox(this._onSelecte dPerspectiveChanged.bind(this)); 140 this._perspectiveSelect = new WebInspector.StatusBarComboBox(this._onSelecte dPerspectiveChanged.bind(this));
141 for (var i = 0; i < this._perspectives.length; ++i) 141 for (var i = 0; i < this._perspectives.length; ++i)
142 this._perspectiveSelect.createOption(this._perspectives[i].title()); 142 this._perspectiveSelect.createOption(this._perspectives[i].title());
143 143
144 this._profile = profile; 144 this._profile = profile;
145 145
146 this._baseSelect = new WebInspector.StatusBarComboBox(this._changeBase.bind( this)); 146 this._baseSelect = new WebInspector.StatusBarComboBox(this._changeBase.bind( this));
147 this._baseSelect.visible = false; 147 this._baseSelect.setVisible(false);
148 this._updateBaseOptions(); 148 this._updateBaseOptions();
149 149
150 this._filterSelect = new WebInspector.StatusBarComboBox(this._changeFilter.b ind(this)); 150 this._filterSelect = new WebInspector.StatusBarComboBox(this._changeFilter.b ind(this));
151 this._filterSelect.visible = false; 151 this._filterSelect.setVisible(false);
152 this._updateFilterOptions(); 152 this._updateFilterOptions();
153 153
154 this._classNameFilter = new WebInspector.StatusBarInput("Class filter"); 154 this._classNameFilter = new WebInspector.StatusBarInput("Class filter");
155 this._classNameFilter.visible = false; 155 this._classNameFilter.setVisible(false);
156 this._constructorsDataGrid.setNameFilter(this._classNameFilter); 156 this._constructorsDataGrid.setNameFilter(this._classNameFilter);
157 this._diffDataGrid.setNameFilter(this._classNameFilter); 157 this._diffDataGrid.setNameFilter(this._classNameFilter);
158 158
159 this._selectedSizeText = new WebInspector.StatusBarText(""); 159 this._selectedSizeText = new WebInspector.StatusBarText("");
160 160
161 this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, thi s._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefine d, true); 161 this._popoverHelper = new WebInspector.ObjectPopoverHelper(this.element, thi s._getHoverAnchor.bind(this), this._resolveObjectForPopover.bind(this), undefine d, true);
162 162
163 this._currentPerspectiveIndex = 0; 163 this._currentPerspectiveIndex = 0;
164 this._currentPerspective = this._perspectives[0]; 164 this._currentPerspective = this._perspectives[0];
165 this._currentPerspective.activate(this); 165 this._currentPerspective.activate(this);
(...skipping 15 matching lines...) Expand all
181 /** 181 /**
182 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 182 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
183 */ 183 */
184 activate: function(heapSnapshotView) { }, 184 activate: function(heapSnapshotView) { },
185 185
186 /** 186 /**
187 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 187 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
188 */ 188 */
189 deactivate: function(heapSnapshotView) 189 deactivate: function(heapSnapshotView)
190 { 190 {
191 heapSnapshotView._baseSelect.visible = false; 191 heapSnapshotView._baseSelect.setVisible(false);
192 heapSnapshotView._filterSelect.visible = false; 192 heapSnapshotView._filterSelect.setVisible(false);
193 heapSnapshotView._classNameFilter.visible = false; 193 heapSnapshotView._classNameFilter.setVisible(false);
194 if (heapSnapshotView._trackingOverviewGrid) 194 if (heapSnapshotView._trackingOverviewGrid)
195 heapSnapshotView._trackingOverviewGrid.detach(); 195 heapSnapshotView._trackingOverviewGrid.detach();
196 if (heapSnapshotView._allocationView) 196 if (heapSnapshotView._allocationView)
197 heapSnapshotView._allocationView.detach(); 197 heapSnapshotView._allocationView.detach();
198 if (heapSnapshotView._statisticsView) 198 if (heapSnapshotView._statisticsView)
199 heapSnapshotView._statisticsView.detach(); 199 heapSnapshotView._statisticsView.detach();
200 200
201 heapSnapshotView._splitView.detach(); 201 heapSnapshotView._splitView.detach();
202 heapSnapshotView._splitView.detachChildViews(); 202 heapSnapshotView._splitView.detachChildViews();
203 }, 203 },
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 WebInspector.HeapSnapshotView.SummaryPerspective.prototype = { 240 WebInspector.HeapSnapshotView.SummaryPerspective.prototype = {
241 /** 241 /**
242 * @override 242 * @override
243 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 243 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
244 */ 244 */
245 activate: function(heapSnapshotView) 245 activate: function(heapSnapshotView)
246 { 246 {
247 heapSnapshotView._constructorsView.show(heapSnapshotView._splitView.main Element()); 247 heapSnapshotView._constructorsView.show(heapSnapshotView._splitView.main Element());
248 heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sid ebarElement()); 248 heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sid ebarElement());
249 heapSnapshotView._splitView.show(heapSnapshotView._searchableView.elemen t); 249 heapSnapshotView._splitView.show(heapSnapshotView._searchableView.elemen t);
250 heapSnapshotView._filterSelect.visible = true; 250 heapSnapshotView._filterSelect.setVisible(true);
251 heapSnapshotView._classNameFilter.visible = true; 251 heapSnapshotView._classNameFilter.setVisible(true);
252 if (heapSnapshotView._trackingOverviewGrid) { 252 if (heapSnapshotView._trackingOverviewGrid) {
253 heapSnapshotView._trackingOverviewGrid.show(heapSnapshotView._search ableView.element, heapSnapshotView._splitView.element); 253 heapSnapshotView._trackingOverviewGrid.show(heapSnapshotView._search ableView.element, heapSnapshotView._splitView.element);
254 heapSnapshotView._trackingOverviewGrid.update(); 254 heapSnapshotView._trackingOverviewGrid.update();
255 heapSnapshotView._trackingOverviewGrid._updateGrid(); 255 heapSnapshotView._trackingOverviewGrid._updateGrid();
256 } 256 }
257 }, 257 },
258 258
259 /** 259 /**
260 * @override 260 * @override
261 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 261 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
(...skipping 28 matching lines...) Expand all
290 WebInspector.HeapSnapshotView.ComparisonPerspective.prototype = { 290 WebInspector.HeapSnapshotView.ComparisonPerspective.prototype = {
291 /** 291 /**
292 * @override 292 * @override
293 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 293 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
294 */ 294 */
295 activate: function(heapSnapshotView) 295 activate: function(heapSnapshotView)
296 { 296 {
297 heapSnapshotView._diffView.show(heapSnapshotView._splitView.mainElement( )); 297 heapSnapshotView._diffView.show(heapSnapshotView._splitView.mainElement( ));
298 heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sid ebarElement()); 298 heapSnapshotView._objectDetailsView.show(heapSnapshotView._splitView.sid ebarElement());
299 heapSnapshotView._splitView.show(heapSnapshotView._searchableView.elemen t); 299 heapSnapshotView._splitView.show(heapSnapshotView._searchableView.elemen t);
300 heapSnapshotView._baseSelect.visible = true; 300 heapSnapshotView._baseSelect.setVisible(true);
301 heapSnapshotView._classNameFilter.visible = true; 301 heapSnapshotView._classNameFilter.setVisible(true);
302 }, 302 },
303 303
304 /** 304 /**
305 * @override 305 * @override
306 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView 306 * @param {!WebInspector.HeapSnapshotView} heapSnapshotView
307 * @return {?WebInspector.DataGrid} 307 * @return {?WebInspector.DataGrid}
308 */ 308 */
309 masterGrid: function(heapSnapshotView) 309 masterGrid: function(heapSnapshotView)
310 { 310 {
311 return heapSnapshotView._diffDataGrid; 311 return heapSnapshotView._diffDataGrid;
(...skipping 1892 matching lines...) Expand 10 before | Expand all | Expand 10 after
2204 name.textContent = frame.functionName; 2204 name.textContent = frame.functionName;
2205 if (frame.scriptId) { 2205 if (frame.scriptId) {
2206 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ; 2206 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ;
2207 frameDiv.appendChild(urlElement); 2207 frameDiv.appendChild(urlElement);
2208 } 2208 }
2209 } 2209 }
2210 }, 2210 },
2211 2211
2212 __proto__: WebInspector.View.prototype 2212 __proto__: WebInspector.View.prototype
2213 } 2213 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/profiler/CPUProfileView.js ('k') | Source/devtools/front_end/profiler/ProfilesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698