Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index 51e2d18d9d835d61e3e1892b2f4267ce5dcfa99a..68e609cd6d6ed2ffe18cc11e5a97b4001b266ca1 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -57,6 +57,7 @@
#include "chrome/browser/ui/browser_tabrestore.h"
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/browser/ui/host_desktop.h"
#include "chrome/browser/ui/startup/autolaunch_prompt.h"
@@ -339,7 +340,8 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,
if (extension) {
RecordCmdLineAppHistogram(extensions::Manifest::TYPE_PLATFORM_APP);
AppLaunchParams params(profile, extension,
- extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW);
+ extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,
+ extensions::SOURCE_COMMAND_LINE);
params.command_line = command_line_;
params.current_directory = cur_dir_;
// If we are being launched from the command line, default to native
@@ -427,9 +429,9 @@ bool StartupBrowserCreatorImpl::OpenApplicationTab(Profile* profile) {
RecordCmdLineAppHistogram(extension->GetType());
- WebContents* app_tab = OpenApplication(AppLaunchParams(
- profile, extension, extensions::LAUNCH_CONTAINER_TAB,
- NEW_FOREGROUND_TAB));
+ WebContents* app_tab = OpenApplication(
+ AppLaunchParams(profile, extension, extensions::LAUNCH_CONTAINER_TAB,
+ NEW_FOREGROUND_TAB, extensions::SOURCE_COMMAND_LINE));
return (app_tab != NULL);
}
@@ -463,7 +465,8 @@ bool StartupBrowserCreatorImpl::OpenApplicationWindow(
RecordCmdLineAppHistogram(extension->GetType());
- AppLaunchParams params(profile, extension, launch_container, NEW_WINDOW);
+ AppLaunchParams params(profile, extension, launch_container, NEW_WINDOW,
+ extensions::SOURCE_COMMAND_LINE);
params.command_line = command_line_;
params.current_directory = cur_dir_;
WebContents* tab_in_app_window = OpenApplication(params);

Powered by Google App Engine
This is Rietveld 408576698