chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Unified Diff: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc » ('j') | chrome/browser/ui/chrome_pages.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

diff --git a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

index f616847648f526750f66d878e40ff2bb7a6b4cd8..fed084de852771ae13020c84dfa38e26485d8734 100644

--- a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

+++ b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc

@@ -12,12 +12,14 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"

#include "chrome/browser/ui/webui/chrome_web_contents_handler.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_contents.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/common/constants.h"

ChromeNewWindowDelegateChromeos::ChromeNewWindowDelegateChromeos() {}

ChromeNewWindowDelegateChromeos::~ChromeNewWindowDelegateChromeos() {}

@@ -37,10 +39,9 @@ void ChromeNewWindowDelegateChromeos::OpenFileManager() {

service->GetInstalledExtension(kFileManagerAppId);

// event_flags = 0 means this invokes the same behavior as the launcher

// item is clicked without any keyboard modifiers.

- OpenApplication(AppLaunchParams(profile,

- extension,

- 0 /* event_flags */,

- chrome::HOST_DESKTOP_TYPE_ASH));

+ OpenApplication(AppLaunchParams(profile, extension, 0 /* event_flags */,

sky 2014/11/19 16:52:08 Seems like there should be a constant for 0.

cylee1 2014/11/19 17:51:17 After tracking down the code I feel it's better to

cylee1 2014/11/20 15:16:51 Introduced some bug in patch set 5, fixed in patch

+ chrome::HOST_DESKTOP_TYPE_ASH,

+ extensions::SOURCE_CHROME_INTERNAL));

}

void ChromeNewWindowDelegateChromeos::OpenCrosh() {