Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3149)

Unified Diff: chrome/test/remoting/remote_desktop_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/remoting/remote_desktop_browsertest.cc
diff --git a/chrome/test/remoting/remote_desktop_browsertest.cc b/chrome/test/remoting/remote_desktop_browsertest.cc
index 82bf6e72ade37b0c6d0c74ce8a67760441b1272e..fb73507fbfe4702b62f6737e92c6d0ed442b5740 100644
--- a/chrome/test/remoting/remote_desktop_browsertest.cc
+++ b/chrome/test/remoting/remote_desktop_browsertest.cc
@@ -10,6 +10,7 @@
#include "base/path_service.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/unpacked_installer.h"
+#include "chrome/browser/ui/extensions/app_launch_params.h"
#include "chrome/browser/ui/extensions/application_launch.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/remoting/key_code_conv.h"
@@ -176,12 +177,12 @@ void RemoteDesktopBrowserTest::LaunchChromotingApp() {
// till the chromoting main page is loaded.
PageLoadNotificationObserver observer(chromoting_main);
- OpenApplication(AppLaunchParams(
- browser()->profile(),
- extension_,
- is_platform_app() ? extensions::LAUNCH_CONTAINER_NONE :
- extensions::LAUNCH_CONTAINER_TAB,
- is_platform_app() ? NEW_WINDOW : CURRENT_TAB));
+ OpenApplication(AppLaunchParams(browser()->profile(), extension_,
+ is_platform_app()
+ ? extensions::LAUNCH_CONTAINER_NONE
+ : extensions::LAUNCH_CONTAINER_TAB,
+ is_platform_app() ? NEW_WINDOW : CURRENT_TAB,
+ extensions::SOURCE_UNTRACKED));
observer.Wait();

Powered by Google App Engine
This is Rietveld 408576698