chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

diff --git a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

index 4e23d74875d3fcba85eb247f2c7b81e4ba94743c..942d8b1bd5c1f23717b8e577df00d986b05d4a62 100644

--- a/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

+++ b/chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc

@@ -25,6 +25,7 @@

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_iterator.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/web_applications/web_app.h"

#include "chrome/browser/web_applications/web_app_win.h"

@@ -34,6 +35,7 @@

#include "chrome/test/base/in_process_browser_test.h"

#include "chrome/test/base/test_switches.h"

#include "content/public/test/test_utils.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "ui/views/win/hwnd_util.h"

@@ -242,10 +244,9 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowPropertyManagerTest, DISABLED_HostedApp) {

LoadExtension(test_data_dir_.AppendASCII("app/"));

EXPECT_TRUE(extension);

- OpenApplication(AppLaunchParams(browser()->profile(),

- extension,

- extensions::LAUNCH_CONTAINER_WINDOW,

- NEW_FOREGROUND_TAB));

+ OpenApplication(AppLaunchParams(

+ browser()->profile(), extension, extensions::LAUNCH_CONTAINER_WINDOW,

+ NEW_FOREGROUND_TAB, extensions::SOURCE_UNTRACKED));

// Check that the new browser has an app name.

// The launch should have created a new browser.