Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3265)

Unified Diff: chrome/browser/ui/extensions/app_launch_params.h

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/app_launch_params.h
diff --git a/chrome/browser/ui/extensions/app_launch_params.h b/chrome/browser/ui/extensions/app_launch_params.h
index a65ed757d8d3dbb086ed52eb53fbf242ef315fb7..5b66cecbff6798832010e09b0e19007e18f1bdfe 100644
--- a/chrome/browser/ui/extensions/app_launch_params.h
+++ b/chrome/browser/ui/extensions/app_launch_params.h
@@ -26,13 +26,15 @@ struct AppLaunchParams {
AppLaunchParams(Profile* profile,
const extensions::Extension* extension,
extensions::LaunchContainer container,
- WindowOpenDisposition disposition);
+ WindowOpenDisposition disposition,
+ extensions::AppLaunchSource source);
// Helper to create AppLaunchParams using extensions::GetLaunchContainer with
// LAUNCH_TYPE_REGULAR to check for a user-configured container.
AppLaunchParams(Profile* profile,
const extensions::Extension* extension,
- WindowOpenDisposition disposition);
+ WindowOpenDisposition disposition,
+ extensions::AppLaunchSource source);
// Helper to create AppLaunchParams using event flags that allows user to
// override the user-configured container using modifier keys, falling back to
@@ -40,8 +42,9 @@ struct AppLaunchParams {
// indicates the desktop upon which to launch (Ash or Native).
AppLaunchParams(Profile* profile,
const extensions::Extension* extension,
- int event_flags,
- chrome::HostDesktopType desktop_type);
+ WindowOpenDisposition disposition,
+ chrome::HostDesktopType desktop_type,
+ extensions::AppLaunchSource source);
~AppLaunchParams();
« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm ('k') | chrome/browser/ui/extensions/app_launch_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698