chrome/browser/policy/policy_browsertest.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor_browsertest.cc ('k') | chrome/browser/search/hotword_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index 939d360d133352da43fca46b82c7675a028979ca..f450b7cfa8785a2681cff51187a07f74d034c4d2 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -69,6 +69,8 @@

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

+#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/ui/host_desktop.h"

#include "chrome/browser/ui/location_bar/location_bar.h"

#include "chrome/browser/ui/omnibox/omnibox_edit_model.h"

@@ -2435,10 +2437,9 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, FullscreenAllowedApp) {

// Launch an app that tries to open a fullscreen window.

TestAddAppWindowObserver add_window_observer(

extensions::AppWindowRegistry::Get(browser()->profile()));

- OpenApplication(AppLaunchParams(browser()->profile(),

- extension,

- extensions::LAUNCH_CONTAINER_NONE,

- NEW_WINDOW));

+ OpenApplication(AppLaunchParams(browser()->profile(), extension,

+ extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,

+ extensions::SOURCE_UNTRACKED));

extensions::AppWindow* window = add_window_observer.WaitForAppWindow();

ASSERT_TRUE(window);

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor_browsertest.cc ('k') | chrome/browser/search/hotword_service.cc » ('j') | no next file with comments »