chrome/browser/extensions/extension_apitest.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc ('k') | chrome/browser/extensions/extension_storage_monitor_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_apitest.cc

diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc

index ecf88fd1fdbf207d5c1deee8b83caa1c64eaae4b..d8c696f06107e4a14e3d54ed62f117296719ea51 100644

--- a/chrome/browser/extensions/extension_apitest.cc

+++ b/chrome/browser/extensions/extension_apitest.cc

@@ -11,11 +11,13 @@

#include "chrome/browser/extensions/unpacked_installer.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/test/base/ui_test_utils.h"

#include "extensions/browser/api/test/test_api.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_set.h"

#include "extensions/test/result_catcher.h"

@@ -308,10 +310,9 @@ bool ExtensionApiTest::RunExtensionTestImpl(const std::string& extension_name,

else

ui_test_utils::NavigateToURL(browser(), url);

} else if (launch_platform_app) {

- AppLaunchParams params(browser()->profile(),

- extension,

- extensions::LAUNCH_CONTAINER_NONE,

- NEW_WINDOW);

+ AppLaunchParams params(browser()->profile(), extension,

+ extensions::LAUNCH_CONTAINER_NONE, NEW_WINDOW,

+ extensions::SOURCE_UNTRACKED);

params.command_line = *CommandLine::ForCurrentProcess();

OpenApplication(params);

}