chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/first_run/first_run.cc ('k') | chrome/browser/chromeos/policy/device_local_account_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc

diff --git a/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc b/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc

index 466638fe9ec02d5af5fd9c1b32b1c1f112da5d85..6be11b895d9e117c323bd0ae6afa70ac9287a08e 100644

--- a/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc

+++ b/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc

@@ -14,6 +14,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

@@ -22,6 +23,7 @@

#include "chromeos/network/network_state_handler.h"

#include "components/user_manager/user_manager.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "ui/base/window_open_disposition.h"

@@ -92,8 +94,9 @@ void DemoAppLauncher::OnProfileLoaded(Profile* profile) {

false,

chromeos::network_handler::ErrorCallback());

- OpenApplication(AppLaunchParams(

- profile, extension, extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW));

+ OpenApplication(

+ AppLaunchParams(profile, extension, extensions::LAUNCH_CONTAINER_WINDOW,

+ NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));

InitAppSession(profile, extension_id);

user_manager::UserManager::Get()->SessionStarted();