Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: extensions/browser/api/app_runtime/app_runtime_api.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_runtime/app_runtime_api.cc
diff --git a/extensions/browser/api/app_runtime/app_runtime_api.cc b/extensions/browser/api/app_runtime/app_runtime_api.cc
index 13ac1beb5516add75e1a900db48bae946c8e55a8..dfee0f60b4bfa1c9d4747bc815c19a0b5732cbfc 100644
--- a/extensions/browser/api/app_runtime/app_runtime_api.cc
+++ b/extensions/browser/api/app_runtime/app_runtime_api.cc
@@ -91,6 +91,19 @@ app_runtime::LaunchSource getLaunchSourceEnum(
case extensions::SOURCE_KEYBOARD:
return app_runtime::LAUNCH_SOURCE_KEYBOARD;
+ case extensions::SOURCE_SETTINGS_PAGE:
+ return app_runtime::LAUNCH_SOURCE_SETTINGS_PAGE;
+ case extensions::SOURCE_MANAGEMENT_API:
+ return app_runtime::LAUNCH_SOURCE_MANAGEMENT_API;
+ case extensions::SOURCE_EPHEMERAL:
+ return app_runtime::LAUNCH_SOURCE_EPHEMERAL;
+ case extensions::SOURCE_BACKGROUND:
+ return app_runtime::LAUNCH_SOURCE_BACKGROUND;
+ case extensions::SOURCE_KIOSK:
+ return app_runtime::LAUNCH_SOURCE_KIOSK;
+ case extensions::SOURCE_CHROME_INTERNAL:
+ return app_runtime::LAUNCH_SOURCE_CHROME_INTERNAL;
+
default:
return app_runtime::LAUNCH_SOURCE_NONE;
}

Powered by Google App Engine
This is Rietveld 408576698