chrome/browser/ui/browser_browsertest.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc ('k') | chrome/browser/ui/chrome_pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index ac490162e8a7b0c5dccf7005ff7763aa55fc9f9e..906c10937d32510f8c43a1751a539d13b99c1ce7 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -40,6 +40,7 @@

#include "chrome/browser/ui/browser_tabstrip.h"

#include "chrome/browser/ui/browser_ui_prefs.h"

#include "chrome/browser/ui/browser_window.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/browser/ui/host_desktop.h"

#include "chrome/browser/ui/startup/startup_browser_creator.h"

@@ -82,6 +83,7 @@

#include "content/public/test/test_navigation_observer.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/uninstall_reason.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/extension_set.h"

#include "net/dns/mock_host_resolver.h"

@@ -1338,11 +1340,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) {

const Extension* extension_app = GetExtension();

// Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.

- WebContents* app_window =

- OpenApplication(AppLaunchParams(browser()->profile(),

- extension_app,

- extensions::LAUNCH_CONTAINER_WINDOW,

- NEW_WINDOW));

+ WebContents* app_window = OpenApplication(AppLaunchParams(

+ browser()->profile(), extension_app, extensions::LAUNCH_CONTAINER_WINDOW,

+ NEW_WINDOW, extensions::SOURCE_UNTRACKED));

ASSERT_TRUE(app_window);

DevToolsWindow* devtools_window =

@@ -1532,9 +1532,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {

const Extension* extension_app = GetExtension();

// Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.

- WebContents* app_window = OpenApplication(

- AppLaunchParams(browser()->profile(), extension_app,

- extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW));

+ WebContents* app_window = OpenApplication(AppLaunchParams(

+ browser()->profile(), extension_app, extensions::LAUNCH_CONTAINER_WINDOW,

+ NEW_WINDOW, extensions::SOURCE_UNTRACKED));

ASSERT_TRUE(app_window);

// Apps launched in a window from the NTP have an extensions tab helper but