chrome/browser/search/hotword_service.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/hotword_service.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/signin/easy_unlock_service_regular.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/hotword_service.cc

diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc

index 40fd0b706050c8b4086cb7454fab2e2a1ed75565..ba5ca72f50a9ce80d4bf4e793bf09d9734642737 100644

--- a/chrome/browser/search/hotword_service.cc

+++ b/chrome/browser/search/hotword_service.cc

@@ -21,6 +21,7 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/hotword_audio_history_handler.h"

#include "chrome/browser/search/hotword_service_factory.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

@@ -33,6 +34,7 @@

#include "content/public/common/webplugininfo.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/uninstall_reason.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/one_shot_event.h"

#include "ui/base/l10n/l10n_util.h"

@@ -486,8 +488,9 @@ void HotwordService::LaunchHotwordAudioVerificationApp(

if (!extension)

return;

- OpenApplication(AppLaunchParams(

- profile_, extension, extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW));

+ OpenApplication(

+ AppLaunchParams(profile_, extension, extensions::LAUNCH_CONTAINER_WINDOW,

+ NEW_WINDOW, extensions::SOURCE_CHROME_INTERNAL));

}

HotwordService::LaunchMode