chrome/browser/extensions/extension_storage_monitor_browsertest.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_storage_monitor_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/extensions/extension_apitest.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_storage_monitor_browsertest.cc

diff --git a/chrome/browser/extensions/extension_storage_monitor_browsertest.cc b/chrome/browser/extensions/extension_storage_monitor_browsertest.cc

index d2a39668c3789b683d1dcc9cb9e845146895cbe8..b96930a8ba75cc57f8b41cb16cb9adc0efd97d15 100644

--- a/chrome/browser/extensions/extension_storage_monitor_browsertest.cc

+++ b/chrome/browser/extensions/extension_storage_monitor_browsertest.cc

@@ -9,12 +9,14 @@

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_storage_monitor.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "content/public/test/test_utils.h"

#include "extensions/browser/extension_prefs.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/test_extension_registry_observer.h"

+#include "extensions/common/constants.h"

#include "extensions/test/extension_test_message_listener.h"

#include "ui/message_center/message_center.h"

#include "ui/message_center/message_center_observer.h"

@@ -179,8 +181,8 @@ class ExtensionStorageMonitorTest : public ExtensionBrowserTest {

NotificationObserver notification_observer(

GetNotificationId(extension->id()));

- OpenApplication(AppLaunchParams(

- profile(), extension, LAUNCH_CONTAINER_NONE, NEW_WINDOW));

+ OpenApplication(AppLaunchParams(profile(), extension, LAUNCH_CONTAINER_NONE,

+ NEW_WINDOW, extensions::SOURCE_UNTRACKED));

ASSERT_TRUE(launched_listener.WaitUntilSatisfied());

// Instruct the app to write |num_bytes| of data.