chrome/browser/chromeos/app_mode/startup_app_launcher.cc - Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/startup_app_launcher.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« athena/extensions/chrome/extensions_delegate_impl.cc ('K') | « chrome/browser/background/background_mode_manager.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_manager_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/startup_app_launcher.cc

diff --git a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

index 6a2451e6567c788c8f69ac65428e33b62212c95e..4bdd7dd6ce48ac1ce6f32ad2953fbb741a03bb57 100644

--- a/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

+++ b/chrome/browser/chromeos/app_mode/startup_app_launcher.cc

@@ -22,6 +22,7 @@

#include "chrome/browser/lifetime/application_lifetime.h"

#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"

#include "chrome/browser/signin/signin_manager_factory.h"

+#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/common/chrome_switches.h"

@@ -33,6 +34,7 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_system.h"

+#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "extensions/common/manifest_handlers/kiosk_mode_info.h"

#include "extensions/common/manifest_handlers/offline_enabled_info.h"

@@ -331,7 +333,7 @@ void StartupAppLauncher::LaunchApp() {

// Always open the app in a window.

OpenApplication(AppLaunchParams(profile_, extension,

extensions::LAUNCH_CONTAINER_WINDOW,

- NEW_WINDOW));

+ NEW_WINDOW, extensions::SOURCE_KIOSK));

InitAppSession(profile_, app_id_);

user_manager::UserManager::Get()->SessionStarted();