Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/ui/browser_browsertest.cc

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 22 matching lines...) Expand all
33 #include "chrome/browser/translate/cld_data_harness_factory.h" 33 #include "chrome/browser/translate/cld_data_harness_factory.h"
34 #include "chrome/browser/ui/browser.h" 34 #include "chrome/browser/ui/browser.h"
35 #include "chrome/browser/ui/browser_command_controller.h" 35 #include "chrome/browser/ui/browser_command_controller.h"
36 #include "chrome/browser/ui/browser_commands.h" 36 #include "chrome/browser/ui/browser_commands.h"
37 #include "chrome/browser/ui/browser_finder.h" 37 #include "chrome/browser/ui/browser_finder.h"
38 #include "chrome/browser/ui/browser_iterator.h" 38 #include "chrome/browser/ui/browser_iterator.h"
39 #include "chrome/browser/ui/browser_navigator.h" 39 #include "chrome/browser/ui/browser_navigator.h"
40 #include "chrome/browser/ui/browser_tabstrip.h" 40 #include "chrome/browser/ui/browser_tabstrip.h"
41 #include "chrome/browser/ui/browser_ui_prefs.h" 41 #include "chrome/browser/ui/browser_ui_prefs.h"
42 #include "chrome/browser/ui/browser_window.h" 42 #include "chrome/browser/ui/browser_window.h"
43 #include "chrome/browser/ui/extensions/app_launch_params.h"
43 #include "chrome/browser/ui/extensions/application_launch.h" 44 #include "chrome/browser/ui/extensions/application_launch.h"
44 #include "chrome/browser/ui/host_desktop.h" 45 #include "chrome/browser/ui/host_desktop.h"
45 #include "chrome/browser/ui/startup/startup_browser_creator.h" 46 #include "chrome/browser/ui/startup/startup_browser_creator.h"
46 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h" 47 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
47 #include "chrome/browser/ui/tabs/pinned_tab_codec.h" 48 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
48 #include "chrome/browser/ui/tabs/tab_strip_model.h" 49 #include "chrome/browser/ui/tabs/tab_strip_model.h"
49 #include "chrome/common/chrome_switches.h" 50 #include "chrome/common/chrome_switches.h"
50 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 51 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
51 #include "chrome/common/pref_names.h" 52 #include "chrome/common/pref_names.h"
52 #include "chrome/common/url_constants.h" 53 #include "chrome/common/url_constants.h"
(...skipping 24 matching lines...) Expand all
77 #include "content/public/browser/web_contents.h" 78 #include "content/public/browser/web_contents.h"
78 #include "content/public/browser/web_contents_observer.h" 79 #include "content/public/browser/web_contents_observer.h"
79 #include "content/public/common/frame_navigate_params.h" 80 #include "content/public/common/frame_navigate_params.h"
80 #include "content/public/common/renderer_preferences.h" 81 #include "content/public/common/renderer_preferences.h"
81 #include "content/public/common/url_constants.h" 82 #include "content/public/common/url_constants.h"
82 #include "content/public/test/browser_test_utils.h" 83 #include "content/public/test/browser_test_utils.h"
83 #include "content/public/test/test_navigation_observer.h" 84 #include "content/public/test/test_navigation_observer.h"
84 #include "extensions/browser/extension_registry.h" 85 #include "extensions/browser/extension_registry.h"
85 #include "extensions/browser/extension_system.h" 86 #include "extensions/browser/extension_system.h"
86 #include "extensions/browser/uninstall_reason.h" 87 #include "extensions/browser/uninstall_reason.h"
88 #include "extensions/common/constants.h"
87 #include "extensions/common/extension.h" 89 #include "extensions/common/extension.h"
88 #include "extensions/common/extension_set.h" 90 #include "extensions/common/extension_set.h"
89 #include "net/dns/mock_host_resolver.h" 91 #include "net/dns/mock_host_resolver.h"
90 #include "net/test/spawned_test_server/spawned_test_server.h" 92 #include "net/test/spawned_test_server/spawned_test_server.h"
91 #include "ui/base/l10n/l10n_util.h" 93 #include "ui/base/l10n/l10n_util.h"
92 #include "ui/base/page_transition_types.h" 94 #include "ui/base/page_transition_types.h"
93 95
94 #if defined(OS_MACOSX) 96 #if defined(OS_MACOSX)
95 #include "base/mac/mac_util.h" 97 #include "base/mac/mac_util.h"
96 #include "base/mac/scoped_nsautorelease_pool.h" 98 #include "base/mac/scoped_nsautorelease_pool.h"
(...skipping 1235 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 // bar settings are correct. 1334 // bar settings are correct.
1333 IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) { 1335 IN_PROC_BROWSER_TEST_F(BrowserTest, ShouldShowLocationBar) {
1334 ASSERT_TRUE(test_server()->Start()); 1336 ASSERT_TRUE(test_server()->Start());
1335 1337
1336 // Load an app. 1338 // Load an app.
1337 host_resolver()->AddRule("www.example.com", "127.0.0.1"); 1339 host_resolver()->AddRule("www.example.com", "127.0.0.1");
1338 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("app/"))); 1340 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("app/")));
1339 const Extension* extension_app = GetExtension(); 1341 const Extension* extension_app = GetExtension();
1340 1342
1341 // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would. 1343 // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
1342 WebContents* app_window = 1344 WebContents* app_window = OpenApplication(AppLaunchParams(
1343 OpenApplication(AppLaunchParams(browser()->profile(), 1345 browser()->profile(), extension_app, extensions::LAUNCH_CONTAINER_WINDOW,
1344 extension_app, 1346 NEW_WINDOW, extensions::SOURCE_UNTRACKED));
1345 extensions::LAUNCH_CONTAINER_WINDOW,
1346 NEW_WINDOW));
1347 ASSERT_TRUE(app_window); 1347 ASSERT_TRUE(app_window);
1348 1348
1349 DevToolsWindow* devtools_window = 1349 DevToolsWindow* devtools_window =
1350 DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), false); 1350 DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), false);
1351 1351
1352 // The launch should have created a new app browser and a dev tools browser. 1352 // The launch should have created a new app browser and a dev tools browser.
1353 ASSERT_EQ(3u, 1353 ASSERT_EQ(3u,
1354 chrome::GetBrowserCount(browser()->profile(), 1354 chrome::GetBrowserCount(browser()->profile(),
1355 browser()->host_desktop_type())); 1355 browser()->host_desktop_type()));
1356 1356
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
1526 #if !defined(OS_MACOSX) 1526 #if !defined(OS_MACOSX)
1527 IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) { 1527 IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {
1528 ASSERT_TRUE(test_server()->Start()); 1528 ASSERT_TRUE(test_server()->Start());
1529 1529
1530 // Load an app 1530 // Load an app
1531 host_resolver()->AddRule("www.example.com", "127.0.0.1"); 1531 host_resolver()->AddRule("www.example.com", "127.0.0.1");
1532 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("app/"))); 1532 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("app/")));
1533 const Extension* extension_app = GetExtension(); 1533 const Extension* extension_app = GetExtension();
1534 1534
1535 // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would. 1535 // Launch it in a window, as AppLauncherHandler::HandleLaunchApp() would.
1536 WebContents* app_window = OpenApplication( 1536 WebContents* app_window = OpenApplication(AppLaunchParams(
1537 AppLaunchParams(browser()->profile(), extension_app, 1537 browser()->profile(), extension_app, extensions::LAUNCH_CONTAINER_WINDOW,
1538 extensions::LAUNCH_CONTAINER_WINDOW, NEW_WINDOW)); 1538 NEW_WINDOW, extensions::SOURCE_UNTRACKED));
1539 ASSERT_TRUE(app_window); 1539 ASSERT_TRUE(app_window);
1540 1540
1541 // Apps launched in a window from the NTP have an extensions tab helper but 1541 // Apps launched in a window from the NTP have an extensions tab helper but
1542 // do not have extension_app set in it. 1542 // do not have extension_app set in it.
1543 ASSERT_TRUE(extensions::TabHelper::FromWebContents(app_window)); 1543 ASSERT_TRUE(extensions::TabHelper::FromWebContents(app_window));
1544 EXPECT_FALSE( 1544 EXPECT_FALSE(
1545 extensions::TabHelper::FromWebContents(app_window)->extension_app()); 1545 extensions::TabHelper::FromWebContents(app_window)->extension_app());
1546 EXPECT_EQ(extensions::AppLaunchInfo::GetFullLaunchURL(extension_app), 1546 EXPECT_EQ(extensions::AppLaunchInfo::GetFullLaunchURL(extension_app),
1547 app_window->GetURL()); 1547 app_window->GetURL());
1548 1548
(...skipping 1102 matching lines...) Expand 10 before | Expand all | Expand 10 after
2651 #endif 2651 #endif
2652 EXPECT_EQ(exp_commit_size, rwhv_commit_size2); 2652 EXPECT_EQ(exp_commit_size, rwhv_commit_size2);
2653 EXPECT_EQ(exp_commit_size, wcv_commit_size2); 2653 EXPECT_EQ(exp_commit_size, wcv_commit_size2);
2654 gfx::Size exp_final_size(initial_wcv_size); 2654 gfx::Size exp_final_size(initial_wcv_size);
2655 exp_final_size.Enlarge(wcv_resize_insets.width(), 2655 exp_final_size.Enlarge(wcv_resize_insets.width(),
2656 wcv_resize_insets.height() + height_inset); 2656 wcv_resize_insets.height() + height_inset);
2657 EXPECT_EQ(exp_final_size, 2657 EXPECT_EQ(exp_final_size,
2658 web_contents->GetRenderWidgetHostView()->GetViewBounds().size()); 2658 web_contents->GetRenderWidgetHostView()->GetViewBounds().size());
2659 EXPECT_EQ(exp_final_size, web_contents->GetContainerBounds().size()); 2659 EXPECT_EQ(exp_final_size, web_contents->GetContainerBounds().size());
2660 } 2660 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698