Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: extensions/common/constants.h

Issue 722703002: Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/common/api/app_runtime.idl ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_CONSTANTS_H_ 5 #ifndef EXTENSIONS_COMMON_CONSTANTS_H_
6 #define EXTENSIONS_COMMON_CONSTANTS_H_ 6 #define EXTENSIONS_COMMON_CONSTANTS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "ui/base/layout.h" 10 #include "ui/base/layout.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 extern const char kMimeTypeJpeg[]; 105 extern const char kMimeTypeJpeg[];
106 extern const char kMimeTypePng[]; 106 extern const char kMimeTypePng[];
107 107
108 // The extension id of the Web Store component application. 108 // The extension id of the Web Store component application.
109 extern const char kWebStoreAppId[]; 109 extern const char kWebStoreAppId[];
110 110
111 // Enumeration of possible app launch sources. 111 // Enumeration of possible app launch sources.
112 // Note the enumeration is used in UMA histogram so entries 112 // Note the enumeration is used in UMA histogram so entries
113 // should not be re-ordered or removed. 113 // should not be re-ordered or removed.
114 enum AppLaunchSource { 114 enum AppLaunchSource {
115 SOURCE_UNTRACKED = 0, 115 SOURCE_UNTRACKED = 0, // Should be used in test.
116 SOURCE_APP_LAUNCHER, 116 SOURCE_APP_LAUNCHER,
117 SOURCE_NEW_TAB_PAGE, 117 SOURCE_NEW_TAB_PAGE,
118 SOURCE_RELOAD, 118 SOURCE_RELOAD,
119 SOURCE_RESTART, 119 SOURCE_RESTART,
120 SOURCE_LOAD_AND_LAUNCH, 120 SOURCE_LOAD_AND_LAUNCH,
121 SOURCE_COMMAND_LINE, 121 SOURCE_COMMAND_LINE,
122 SOURCE_FILE_HANDLER, 122 SOURCE_FILE_HANDLER,
123 SOURCE_URL_HANDLER, 123 SOURCE_URL_HANDLER,
124
125 SOURCE_SYSTEM_TRAY, 124 SOURCE_SYSTEM_TRAY,
126 SOURCE_ABOUT_PAGE, 125 SOURCE_ABOUT_PAGE,
127 SOURCE_KEYBOARD, 126 SOURCE_KEYBOARD,
127 SOURCE_EXTENSIONS_PAGE,
128 SOURCE_MANAGEMENT_API,
129 SOURCE_EPHEMERAL_APP,
130 SOURCE_BACKGROUND,
131 SOURCE_KIOSK,
132 SOURCE_CHROME_INTERNAL,
128 133
129 NUM_APP_LAUNCH_SOURCES 134 NUM_APP_LAUNCH_SOURCES
130 }; 135 };
131 136
132 // This enum is used for the launch type the user wants to use for an 137 // This enum is used for the launch type the user wants to use for an
133 // application. 138 // application.
134 // Do not remove items or re-order this enum as it is used in preferences 139 // Do not remove items or re-order this enum as it is used in preferences
135 // and histograms. 140 // and histograms.
136 enum LaunchType { 141 enum LaunchType {
137 LAUNCH_TYPE_INVALID = -1, 142 LAUNCH_TYPE_INVALID = -1,
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 const ui::ScaleFactor scale; 202 const ui::ScaleFactor scale;
198 }; 203 };
199 204
200 // The icon representations for extension actions. 205 // The icon representations for extension actions.
201 extern const IconRepresentationInfo kExtensionActionIconSizes[]; 206 extern const IconRepresentationInfo kExtensionActionIconSizes[];
202 const size_t kNumExtensionActionIconSizes = 2u; 207 const size_t kNumExtensionActionIconSizes = 2u;
203 208
204 } // namespace extension_misc 209 } // namespace extension_misc
205 210
206 #endif // EXTENSIONS_COMMON_CONSTANTS_H_ 211 #endif // EXTENSIONS_COMMON_CONSTANTS_H_
OLDNEW
« no previous file with comments | « extensions/common/api/app_runtime.idl ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698