Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: Source/devtools/front_end/sdk/TracingManager.js

Issue 722693002: DevTools: show progress when retrieving recorded trace events (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/TracingManager.js
diff --git a/Source/devtools/front_end/sdk/TracingManager.js b/Source/devtools/front_end/sdk/TracingManager.js
index 0d31cb9882d275ce639cdf86524a202c1aa6a2f5..3e063d441ad0ace179988794fd75d51893a4cc9c 100644
--- a/Source/devtools/front_end/sdk/TracingManager.js
+++ b/Source/devtools/front_end/sdk/TracingManager.js
@@ -13,10 +13,13 @@ WebInspector.TracingManager = function()
{
WebInspector.Object.call(this);
this._active = false;
+ this._eventBufferSize = 0;
+ this._eventsRetrieved = 0;
WebInspector.targetManager.observeTargets(this);
}
WebInspector.TracingManager.Events = {
+ "RetrieveEventsProgress": "RetrieveEventsProgress",
"BufferUsage": "BufferUsage",
"TracingStarted": "TracingStarted",
"EventsCollected": "EventsCollected",
@@ -63,9 +66,11 @@ WebInspector.TracingManager.prototype = {
/**
* @param {number} usage
+ * @param {number} eventCount
*/
- _bufferUsage: function(usage)
+ _bufferUsage: function(usage, eventCount)
{
+ this._eventBufferSize = eventCount;
this.dispatchEventToListeners(WebInspector.TracingManager.Events.BufferUsage, usage);
},
@@ -75,10 +80,16 @@ WebInspector.TracingManager.prototype = {
_eventsCollected: function(events)
{
this.dispatchEventToListeners(WebInspector.TracingManager.Events.EventsCollected, events);
+ this._eventsRetrieved += events.length;
+ if (this._eventsRetrieved > this._eventBufferSize)
+ this._eventsRetrieved = this._eventBufferSize;
+ this.dispatchEventToListeners(WebInspector.TracingManager.Events.RetrieveEventsProgress, this._eventsRetrieved / this._eventBufferSize);
alph 2014/11/12 15:41:11 division by zero?
yurys 2014/11/17 12:59:37 Done.
},
_tracingComplete: function()
{
+ this._eventBufferSize = 0;
+ this._eventsRetrieved = 0;
this.dispatchEventToListeners(WebInspector.TracingManager.Events.TracingComplete);
},
@@ -130,10 +141,11 @@ WebInspector.TracingDispatcher = function(tracingManager)
WebInspector.TracingDispatcher.prototype = {
/**
* @param {number} usage
+ * @param {number} eventCount
*/
- bufferUsage: function(usage)
+ bufferUsage: function(usage, eventCount)
{
- this._tracingManager._bufferUsage(usage);
+ this._tracingManager._bufferUsage(usage, eventCount);
},
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | Source/devtools/protocol.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698