Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 722693002: DevTools: show progress when retrieving recorded trace events (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: show progress when retrieving recorded trace events The progress is estimated as event count divided by total buffer size. BUG=426117 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185440

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M Source/devtools/front_end/sdk/TracingManager.js View 1 4 chunks +22 lines, -6 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 chunks +10 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
Corresponding Chrome part: https://codereview.chromium.org/717083003/
6 years, 1 month ago (2014-11-12 15:33:28 UTC) #2
alph
lgtm https://codereview.chromium.org/722693002/diff/1/Source/devtools/front_end/sdk/TracingManager.js File Source/devtools/front_end/sdk/TracingManager.js (right): https://codereview.chromium.org/722693002/diff/1/Source/devtools/front_end/sdk/TracingManager.js#newcode86 Source/devtools/front_end/sdk/TracingManager.js:86: this.dispatchEventToListeners(WebInspector.TracingManager.Events.RetrieveEventsProgress, this._eventsRetrieved / this._eventBufferSize); division by zero? https://codereview.chromium.org/722693002/diff/1/Source/devtools/protocol.json ...
6 years, 1 month ago (2014-11-12 15:41:11 UTC) #3
yurys
https://codereview.chromium.org/722693002/diff/1/Source/devtools/front_end/sdk/TracingManager.js File Source/devtools/front_end/sdk/TracingManager.js (right): https://codereview.chromium.org/722693002/diff/1/Source/devtools/front_end/sdk/TracingManager.js#newcode86 Source/devtools/front_end/sdk/TracingManager.js:86: this.dispatchEventToListeners(WebInspector.TracingManager.Events.RetrieveEventsProgress, this._eventsRetrieved / this._eventBufferSize); On 2014/11/12 15:41:11, alph wrote: ...
6 years, 1 month ago (2014-11-17 12:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722693002/20001
6 years, 1 month ago (2014-11-17 13:03:06 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 14:08:29 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185440

Powered by Google App Engine
This is Rietveld 408576698