Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 722663002: HTML math tag should have AXRoleDescription as 'math' (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

HTML math tag should have AXRoleDescription as 'math' According to latest editor's draft http://rawgit.com/w3c/aria/master/html-aam/html-aam.html HTML math tag should be exposed similar to ARIA role math and hence AXRoleDescription for math tag would be 'math. This CL depends on https://codereview.chromium.org/722653002/ BUG=429476 Committed: https://crrev.com/0bc5a9a4430af86f2c935f51e46961988fe576fd Cr-Commit-Position: refs/heads/master@{#304622}

Patch Set 1 #

Patch Set 2 : updating #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M content/app/strings/content_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/math-expected-android.txt View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/accessibility/math-expected-mac.txt View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M content/test/data/accessibility/math-expected-win.txt View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
shreeramk
PTAL. Thanks!!!
6 years, 1 month ago (2014-11-17 06:34:58 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-17 08:21:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722663002/40001
6 years, 1 month ago (2014-11-17 08:22:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24605)
6 years, 1 month ago (2014-11-17 08:25:29 UTC) #7
shreeramk
avi@chromium.org: Please review changes in content_strings.grd Thanks!
6 years, 1 month ago (2014-11-17 08:42:18 UTC) #9
Avi (use Gerrit)
Strings! \o/ LGTM
6 years, 1 month ago (2014-11-18 16:21:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722663002/40001
6 years, 1 month ago (2014-11-18 16:32:08 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-18 16:55:39 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 16:56:30 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0bc5a9a4430af86f2c935f51e46961988fe576fd
Cr-Commit-Position: refs/heads/master@{#304622}

Powered by Google App Engine
This is Rietveld 408576698