Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 722633002: [content/browser/ssl && content/browser/speech] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[content/browser/ssl && content/browser/speech] Convert VLOGs to DVLOGs BUG=101424 Committed: https://crrev.com/d55e6a2a86a60d3fff964b0779f495bbf1419d17 Cr-Commit-Position: refs/heads/master@{#304172}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/speech/google_one_shot_remote_engine.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
anujsharma
xians@chromium.org: Please review changes in speech module palmer@chromium.org: Please review changes in ssl module
6 years, 1 month ago (2014-11-12 13:21:41 UTC) #2
palmer
lgtm
6 years, 1 month ago (2014-11-13 00:10:56 UTC) #3
anujsharma
On 2014/11/13 00:10:56, Chromium Palmer wrote: > lgtm Thanks chromium palmer for lgtm. @xians, could ...
6 years, 1 month ago (2014-11-13 16:58:47 UTC) #4
no longer working on chromium
On 2014/11/13 16:58:47, anujsharma wrote: > On 2014/11/13 00:10:56, Chromium Palmer wrote: > > lgtm ...
6 years, 1 month ago (2014-11-13 22:53:49 UTC) #5
anujsharma
On 2014/11/13 22:53:49, xians1 wrote: > On 2014/11/13 16:58:47, anujsharma wrote: > > On 2014/11/13 ...
6 years, 1 month ago (2014-11-14 02:46:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722633002/1
6 years, 1 month ago (2014-11-14 02:47:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-14 04:13:09 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 04:14:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d55e6a2a86a60d3fff964b0779f495bbf1419d17
Cr-Commit-Position: refs/heads/master@{#304172}

Powered by Google App Engine
This is Rietveld 408576698