Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 722603002: [ServiceWorker] Use the cookie which is differnt from the username in LayoutTest. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Use the cookie which is differnt from the username in LayoutTest. Currently we use the cookie name which is same as the username. But I will add tests which change the username. For the preparation of them, this patch changes LayoutTest to use the cookie which is differnt from the username. BUG=N/A TEST=http/tests/serviceworker Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185265

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-canvas-tainting.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/fetch-cors-xhr.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-access-control-login.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/fetch-access-control-util.js View 3 chunks +10 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
horo
nhiroki@ Could you please review this?
6 years, 1 month ago (2014-11-12 09:34:32 UTC) #3
nhiroki
Change itself looks good. > But I will add tests which change the username. Can ...
6 years, 1 month ago (2014-11-13 03:19:06 UTC) #4
horo
On 2014/11/13 03:19:06, nhiroki wrote: > Change itself looks good. > > > But I ...
6 years, 1 month ago (2014-11-13 03:30:46 UTC) #5
nhiroki
On 2014/11/13 03:30:46, horo wrote: > On 2014/11/13 03:19:06, nhiroki wrote: > > Change itself ...
6 years, 1 month ago (2014-11-13 03:43:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722603002/20001
6 years, 1 month ago (2014-11-13 03:48:18 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 04:19:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as 185265

Powered by Google App Engine
This is Rietveld 408576698