Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 722523003: IDL: Use user-friendly type names for error messages (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Use user-friendly type names for error messages This is a follow-up CL of https://codereview.chromium.org/690923004/. It would be great to show "(A or B)" rather than "AOrB". BUG=240176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M LayoutTests/fast/events/constructors/track-event-constructor-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/scripts/idl_types.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
bashi
PTAL?
6 years, 1 month ago (2014-11-12 08:20:21 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-12 08:27:14 UTC) #3
sof
lgtm This handles nested union types (or typedefs of such) as expected?
6 years, 1 month ago (2014-11-12 08:28:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722523003/1
6 years, 1 month ago (2014-11-12 08:28:46 UTC) #6
bashi
On 2014/11/12 08:28:20, sof wrote: > lgtm > > This handles nested union types (or ...
6 years, 1 month ago (2014-11-12 08:32:24 UTC) #7
sof
On 2014/11/12 08:32:24, bashi1 wrote: > On 2014/11/12 08:28:20, sof wrote: > > lgtm > ...
6 years, 1 month ago (2014-11-12 08:46:35 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 09:53:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185195

Powered by Google App Engine
This is Rietveld 408576698