Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 722513005: Add scoped_ptr to Environment object. (Closed)

Created:
6 years, 1 month ago by Jorge Lucangeli Obes
Modified:
6 years, 1 month ago
Reviewers:
agl, wtc
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add scoped_ptr to Environment object. BUG=None TEST=Compiles. Committed: https://crrev.com/a2b139ffaa11e31423ffd7007071c11cfa6d2ba7 Cr-Commit-Position: refs/heads/master@{#304085}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M crypto/nss_util.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
Jorge Lucangeli Obes
Aren't we leaking the Environment object here?
6 years, 1 month ago (2014-11-13 01:39:45 UTC) #2
agl
lgtm
6 years, 1 month ago (2014-11-13 19:32:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722513005/1
6 years, 1 month ago (2014-11-13 19:37:13 UTC) #5
wtc
Patch set 1 LGTM. Thanks. https://chromiumcodereview.appspot.com/722513005/diff/1/crypto/nss_util.cc File crypto/nss_util.cc (right): https://chromiumcodereview.appspot.com/722513005/diff/1/crypto/nss_util.cc#newcode838 crypto/nss_util.cc:838: scoped_ptr<base::Environment> env(base::Environment::Create()); The object ...
6 years, 1 month ago (2014-11-13 21:00:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-13 21:30:59 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 21:31:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2b139ffaa11e31423ffd7007071c11cfa6d2ba7
Cr-Commit-Position: refs/heads/master@{#304085}

Powered by Google App Engine
This is Rietveld 408576698