Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: media/cast/test/utility/udp_proxy_main.cc

Issue 722503002: Use uint16 for port numbers, misc edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/test/utility/udp_proxy_main.cc
diff --git a/media/cast/test/utility/udp_proxy_main.cc b/media/cast/test/utility/udp_proxy_main.cc
index 212b5976e39f9518925a3365d73422dfc9852e87..00cec4adef709cc6dcf1c71b0215d1e29468050a 100644
--- a/media/cast/test/utility/udp_proxy_main.cc
+++ b/media/cast/test/utility/udp_proxy_main.cc
@@ -144,8 +144,15 @@ int main(int argc, char** argv) {
// V1 proxy
network_type = argv[2];
}
- net::IPEndPoint remote_endpoint(remote_ip_number, remote_port);
- net::IPEndPoint local_endpoint(local_ip_number, local_port);
+ if (local_port < 0 || local_port > 65535 || remote_port < 0 ||
+ remote_port > 65535) {
Peter Kasting 2014/11/12 23:53:55 Again, we probably should have done this already.
+ fprintf(stderr, "Port numbers must be between 0 and 65535\n");
+ exit(1);
+ }
+ net::IPEndPoint remote_endpoint(remote_ip_number,
+ static_cast<uint16>(remote_port));
+ net::IPEndPoint local_endpoint(local_ip_number,
+ static_cast<uint16>(local_port));
scoped_ptr<media::cast::test::PacketPipe> in_pipe, out_pipe;
if (network_type == "perfect") {

Powered by Google App Engine
This is Rietveld 408576698