Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7329)

Unified Diff: chromecast/browser/devtools/remote_debugging_server.cc

Issue 722503002: Use uint16 for port numbers, misc edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/devtools/remote_debugging_server.cc
diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc
index e0abdc072d809f1ad95240596c0aebf611e41328..916e6a4c11fe6c012c274e91b5d9c822381e0e10 100644
--- a/chromecast/browser/devtools/remote_debugging_server.cc
+++ b/chromecast/browser/devtools/remote_debugging_server.cc
@@ -31,7 +31,7 @@ namespace {
const char kFrontEndURL[] =
"https://chrome-devtools-frontend.appspot.com/serve_rev/%s/devtools.html";
-const int kDefaultRemoteDebuggingPort = 9222;
+const uint16 kDefaultRemoteDebuggingPort = 9222;
#if defined(OS_ANDROID)
class UnixDomainServerSocketFactory
@@ -55,7 +55,7 @@ class UnixDomainServerSocketFactory
class TCPServerSocketFactory
: public content::DevToolsHttpHandler::ServerSocketFactory {
public:
- TCPServerSocketFactory(const std::string& address, int port, int backlog)
+ TCPServerSocketFactory(const std::string& address, uint16 port, int backlog)
: content::DevToolsHttpHandler::ServerSocketFactory(
address, port, backlog) {}
@@ -71,7 +71,7 @@ class TCPServerSocketFactory
#endif
scoped_ptr<content::DevToolsHttpHandler::ServerSocketFactory>
-CreateSocketFactory(int port) {
+CreateSocketFactory(uint16 port) {
#if defined(OS_ANDROID)
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
std::string socket_name = "cast_shell_devtools_remote";
@@ -115,10 +115,7 @@ RemoteDebuggingServer::~RemoteDebuggingServer() {
}
void RemoteDebuggingServer::OnPortChanged() {
- int new_port = *pref_port_;
- if (new_port < 0) {
- new_port = 0;
- }
+ uint16 new_port = static_cast<uint16>(std::max(*pref_port_, 0));
VLOG(1) << "OnPortChanged called: old_port=" << port_
<< ", new_port=" << new_port;

Powered by Google App Engine
This is Rietveld 408576698