Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: remoting/protocol/network_settings_unittest.cc

Issue 722503002: Use uint16 for port numbers, misc edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/protocol/network_settings.h" 5 #include "remoting/protocol/network_settings.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace remoting { 9 namespace remoting {
10 namespace protocol { 10 namespace protocol {
11 11
12 TEST(ParsePortRange, Basic) { 12 TEST(ParsePortRange, Basic) {
13 int min, max; 13 uint16 min, max;
14 14
15 // Valid range 15 // Valid range
16 EXPECT_TRUE(NetworkSettings::ParsePortRange("1-65535", &min, &max)); 16 EXPECT_TRUE(NetworkSettings::ParsePortRange("1-65535", &min, &max));
17 EXPECT_EQ(1, min); 17 EXPECT_EQ(1u, min);
18 EXPECT_EQ(65535, max); 18 EXPECT_EQ(65535u, max);
19 19
20 EXPECT_TRUE(NetworkSettings::ParsePortRange(" 1 - 65535 ", &min, &max)); 20 EXPECT_TRUE(NetworkSettings::ParsePortRange(" 1 - 65535 ", &min, &max));
21 EXPECT_EQ(1, min); 21 EXPECT_EQ(1u, min);
22 EXPECT_EQ(65535, max); 22 EXPECT_EQ(65535u, max);
23 23
24 EXPECT_TRUE(NetworkSettings::ParsePortRange("12400-12400", &min, &max)); 24 EXPECT_TRUE(NetworkSettings::ParsePortRange("12400-12400", &min, &max));
25 EXPECT_EQ(12400, min); 25 EXPECT_EQ(12400u, min);
26 EXPECT_EQ(12400, max); 26 EXPECT_EQ(12400u, max);
27 27
28 // Invalid 28 // Invalid
29 EXPECT_FALSE(NetworkSettings::ParsePortRange("", &min, &max)); 29 EXPECT_FALSE(NetworkSettings::ParsePortRange("", &min, &max));
30 EXPECT_FALSE(NetworkSettings::ParsePortRange("-65535", &min, &max)); 30 EXPECT_FALSE(NetworkSettings::ParsePortRange("-65535", &min, &max));
31 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-", &min, &max)); 31 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-", &min, &max));
32 EXPECT_FALSE(NetworkSettings::ParsePortRange("-", &min, &max)); 32 EXPECT_FALSE(NetworkSettings::ParsePortRange("-", &min, &max));
33 EXPECT_FALSE(NetworkSettings::ParsePortRange("-1-65535", &min, &max)); 33 EXPECT_FALSE(NetworkSettings::ParsePortRange("-1-65535", &min, &max));
34 EXPECT_FALSE(NetworkSettings::ParsePortRange("1--65535", &min, &max)); 34 EXPECT_FALSE(NetworkSettings::ParsePortRange("1--65535", &min, &max));
35 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65535-", &min, &max)); 35 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65535-", &min, &max));
36 EXPECT_FALSE(NetworkSettings::ParsePortRange("0-65535", &min, &max)); 36 EXPECT_FALSE(NetworkSettings::ParsePortRange("0-65535", &min, &max));
37 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65536", &min, &max)); 37 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-65536", &min, &max));
38 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-4294967295", &min, &max)); 38 EXPECT_FALSE(NetworkSettings::ParsePortRange("1-4294967295", &min, &max));
39 EXPECT_FALSE(NetworkSettings::ParsePortRange("10-1", &min, &max)); 39 EXPECT_FALSE(NetworkSettings::ParsePortRange("10-1", &min, &max));
40 EXPECT_FALSE(NetworkSettings::ParsePortRange("1foo-2bar", &min, &max)); 40 EXPECT_FALSE(NetworkSettings::ParsePortRange("1foo-2bar", &min, &max));
41 } 41 }
42 42
43 } // namespace protocol 43 } // namespace protocol
44 } // namespace remoting 44 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698