src/nonsfi/linux/linux_pthread_private.c - Issue 722423003: Fix stack alignment of child threads on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/nonsfi/linux/linux_pthread_private.c

Issue 722423003: Fix stack alignment of child threads on ARM. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Add run_stack_alignment_asm_test to nonsfi_tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/nonsfi/linux/linux_pthread_private.c

diff --git a/src/nonsfi/linux/linux_pthread_private.c b/src/nonsfi/linux/linux_pthread_private.c

index cb9316871374b53bc772317a064405c27fa4fb7d..e23337dc2fc5afd9207f4a2ac7e2e7a2564535e9 100644

--- a/src/nonsfi/linux/linux_pthread_private.c

+++ b/src/nonsfi/linux/linux_pthread_private.c

@@ -95,10 +95,10 @@ static int nacl_irt_thread_create(void (*start_func)(void), void *stack,

* In child thread. Clear the frame pointer to

* prevent debuggers from unwinding beyond this,

- * pop the stack to get start_func and call it.

+ * Load start_func from the stack and call it.

Mark Seaborn 2014/12/10 16:28:21 Nit: Lower case "load"

mazda 2014/12/11 03:41:49 Done.

"mov fp, #0\n"

- "pop {r0}\n"

+ "ldr r0, [sp]\n"

"blx r0\n"

/* start_func never finishes. */

"bkpt #0\n"

« no previous file with comments | « SConstruct ('k') | no next file » | no next file with comments »