Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 722373003: Copy unittests binary in android-sync.sh (Closed)

Created:
6 years, 1 month ago by Ian Cullinan
Modified:
6 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Copy unittests binary in android-sync.sh Without this change, `make android_arm.release.check` fails since the unittests binary does not exist on the device. BUG=v8:3695 LOG= Committed: https://chromium.googlesource.com/v8/v8/+/39222a71dbe5d17739b3832e6ab2513476389a62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/android-sync.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ian Cullinan
Hi mstarzinger, PTAL at this one-liner to get the unittests to run on Android. Thanks, ...
6 years, 1 month ago (2014-11-14 00:57:54 UTC) #2
Michael Starzinger
Hey Ian! Thanks for the patch. The change is looking good. Unfortunately I wasn't able ...
6 years, 1 month ago (2014-11-14 16:44:01 UTC) #3
Michael Starzinger
LGTM. Now I found the CLA entry, sorry, was my screw-up.
6 years, 1 month ago (2014-11-18 17:43:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722373003/1
6 years, 1 month ago (2014-11-18 18:08:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 18:36:54 UTC) #7
Ian Cullinan
6 years, 1 month ago (2014-11-18 19:05:04 UTC) #8
Message was sent while issue was closed.
On 2014/11/18 17:43:12, Michael Starzinger wrote:
> LGTM. Now I found the CLA entry, sorry, was my screw-up.

No worries, thanks for the review!

Powered by Google App Engine
This is Rietveld 408576698