Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 722353002: Add development Blink setting for impl-side rubber-banding (Closed)

Created:
6 years, 1 month ago by ccameron
Modified:
6 years, 1 month ago
Reviewers:
pdr., dglazkov, eseidel
CC:
blink-reviews, blink-reviews-rendering, rjwright, zoltan1, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Mike Lawther (Google), dstockwell, Timothy Loh, shans, jchaffraix+rendering, darktears, Steve Block, dglazkov+blink, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add development Blink setting for impl-side rubber-banding Add a flag to indicate if the compositor thread is performing the Mac overscroll rubber-band bounce effect. This is false by default and will be set to true by --enable-threaded-event-handling-mac until developement is finished, whereupon it will be true by default and removed. BUG=133097 TBR=dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M Source/core/frame/FrameView.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
ccameron
(should have) no function changes.
6 years, 1 month ago (2014-11-13 22:34:37 UTC) #3
pdr.
On 2014/11/13 at 22:34:37, ccameron wrote: > (should have) no function changes. LGTM. Was a ...
6 years, 1 month ago (2014-11-14 00:30:44 UTC) #4
ccameron
Thanks! On 2014/11/14 00:30:44, pdr wrote: > On 2014/11/13 at 22:34:37, ccameron wrote: > > ...
6 years, 1 month ago (2014-11-14 00:34:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722353002/1
6 years, 1 month ago (2014-11-14 00:36:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19745)
6 years, 1 month ago (2014-11-14 00:40:47 UTC) #9
ccameron
Adding dglazkov for public/ OWNER
6 years, 1 month ago (2014-11-14 00:42:17 UTC) #11
ccameron
On 2014/11/14 00:42:17, ccameron1 wrote: > Adding dglazkov for public/ OWNER TBRing public/ OWNER since ...
6 years, 1 month ago (2014-11-14 18:04:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722353002/1
6 years, 1 month ago (2014-11-14 18:06:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722353002/1
6 years, 1 month ago (2014-11-14 18:22:41 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 18:51:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185385

Powered by Google App Engine
This is Rietveld 408576698