Cleanup the XML directory in public includes.

Cleanup the XML directory in public includes.

Committed: https://skia.googlesource.com/skia/+/5ae776504fce25d320054390556526403068f103

[djsollen, 2014-11-13 20:54:58]

djsollen@google.com changed reviewers:
+ borenet@google.com, bungeman@google.com, reed@google.com

[reed1, 2014-11-13 20:58:13]

public lgtm

[borenet, 2014-11-13 21:01:26]

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp
File gyp/xml.gyp (right):

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp#newcode10
gyp/xml.gyp:10: 'utils.gyp:utils',
I thought we wanted to avoid dependencies on these "sub-libraries" and use
skia_lib instead?

[djsollen, 2014-11-13 21:06:56]

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp
File gyp/xml.gyp (right):

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp#newcode10
gyp/xml.gyp:10: 'utils.gyp:utils',
On 2014/11/13 21:01:26, borenet wrote:
> I thought we wanted to avoid dependencies on these "sub-libraries" and use
> skia_lib instead?

yeah, but in this case is causes a cycle as ports includes xml so you get.

skia_lib -> ports -> xml -> skia_lib

[bungeman-skia, 2014-11-13 21:50:25]

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp
File gyp/xml.gyp (right):

https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp#newcode10
gyp/xml.gyp:10: 'utils.gyp:utils',
On 2014/11/13 21:06:55, djsollen wrote:
> On 2014/11/13 21:01:26, borenet wrote:
> > I thought we wanted to avoid dependencies on these "sub-libraries" and use
> > skia_lib instead?
> 
> yeah, but in this case is causes a cycle as ports includes xml so you get.
> 
> skia_lib -> ports -> xml -> skia_lib

Doing things this way requires that this target be part of skia_lib. If ports is
using this, then that is a necessary thing anyway, but what in ports is using
this? I thought Android was just using expat directly?

[bungeman-skia, 2014-11-13 22:08:40]

On 2014/11/13 21:50:25, bungeman1 wrote:
> https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp
> File gyp/xml.gyp (right):
> 
> https://codereview.chromium.org/722343002/diff/1/gyp/xml.gyp#newcode10
> gyp/xml.gyp:10: 'utils.gyp:utils',
> On 2014/11/13 21:06:55, djsollen wrote:
> > On 2014/11/13 21:01:26, borenet wrote:
> > > I thought we wanted to avoid dependencies on these "sub-libraries" and use
> > > skia_lib instead?
> > 
> > yeah, but in this case is causes a cycle as ports includes xml so you get.
> > 
> > skia_lib -> ports -> xml -> skia_lib
> 
> Doing things this way requires that this target be part of skia_lib. If ports
is
> using this, then that is a necessary thing anyway, but what in ports is using
> this? I thought Android was just using expat directly?

Actually, it looks like this is just for SkXMLParser_empty.cpp? If so, let's
just be rid of it. If something actually wants it, let's move it out to tolls or
something, because I don't think anything in the skia_lib actually uses it.

[djsollen, 2014-11-14 12:57:56]

ben & eric, please take a second look as this should be good to go.

[borenet, 2014-11-14 12:59:41]

On 2014/11/14 12:57:56, djsollen wrote:
> ben & eric, please take a second look as this should be good to go.

LGTM

[djsollen, 2014-11-14 13:42:52]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-11-14 13:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722343002/60001

[commit-bot: I haz the power, 2014-11-14 13:52:54]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/5ae776504fce25d320054390556526403068f103