Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/interstitial_page_impl.cc

Issue 72233002: Move RenderViewHostManager from WebContents to FrameTreeNode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/frame_tree_node.h ('K') | « content/browser/frame_host/frame_tree_unittest.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/interstitial_page_impl.cc
diff --git a/content/browser/frame_host/interstitial_page_impl.cc b/content/browser/frame_host/interstitial_page_impl.cc
index 68991492d83cb1959b6f064396b87980e0fdc491..8b249e924ecc4b3d9e983a937c61a4e2400424af 100644
--- a/content/browser/frame_host/interstitial_page_impl.cc
+++ b/content/browser/frame_host/interstitial_page_impl.cc
@@ -159,7 +159,9 @@ InterstitialPageImpl::InterstitialPageImpl(
// NavigationControllerImpl to the Navigator, which is separate from
// the WebContents one, so we can enforce no navigation policy here.
// While we get the code to a point to do this, pass NULL for it.
- frame_tree_(new Navigator(NULL, this)),
+ // TODO(creis): We will also need to pass delegates for the RVHM as we
nasko 2013/11/14 08:23:38 TODOs pile on ; )
Charlie Reis 2013/11/14 19:01:16 They certainly do. :)
+ // start to use it.
+ frame_tree_(new Navigator(NULL, this), NULL, NULL, NULL),
original_child_id_(web_contents->GetRenderProcessHost()->GetID()),
original_rvh_id_(web_contents->GetRenderViewHost()->GetRoutingID()),
should_revert_web_contents_title_(false),
« content/browser/frame_host/frame_tree_node.h ('K') | « content/browser/frame_host/frame_tree_unittest.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698