Move RenderViewHostManager from WebContents to FrameTreeNode.

Move RenderViewHostManager from WebContents to FrameTreeNode.

This is a step towards supporting cross-process navigations in subframes.

BUG=314791
TEST=No behavior change.
R=nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235365

[Charlie Reis, 2013-11-14 02:25:20]

Nasko, here's a patch to move RVHM to FTN.

I'm suspicious that there may be a memory error, since I was getting a strange
crash when running the two SitePerProcessBrowserTests back to back (but not
individually).  I'll see if I can diagnose that tomorrow from the try jobs, but
it's ready for a first review pass.  Thanks!

[nasko, 2013-11-14 08:23:37]

Mostly looks good, but I do wonder why it crashes on multiple tests. Couple of
nits.

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree.h (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree.h:45: // RenderViewHostManagers. 
TODO(creis): This set of delegates will change as
nit: TODO on a new line?

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree_node.h (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree_node.h:36: Navigator* navigator,
nit: I'd move this up with the rest of the delegates, as those are all objects
FTN uses and the other parameters are what "identifies" FTN.

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/interstitial_page_impl.cc (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/interstitial_page_impl.cc:162: // TODO(creis): We
will also need to pass delegates for the RVHM as we
TODOs pile on ; )

[Charlie Reis, 2013-11-14 19:01:16]

On 2013/11/14 08:23:37, nasko wrote:
> Mostly looks good, but I do wonder why it crashes on multiple tests. Couple of
> nits.

Good news (for this CL, anyway): those crashes only happen if you pass
--single_process to content_browsertests, and they happen independently of my
CL.  Not entirely sure what's going on there, but this CL doesn't cause it, and
the try jobs were happy.  I think we can proceed.

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree.h (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree.h:45: // RenderViewHostManagers. 
TODO(creis): This set of delegates will change as
On 2013/11/14 08:23:38, nasko wrote:
> nit: TODO on a new line?

Done.

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/frame_tree_node.h (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/frame_tree_node.h:36: Navigator* navigator,
On 2013/11/14 08:23:38, nasko wrote:
> nit: I'd move this up with the rest of the delegates, as those are all objects
> FTN uses and the other parameters are what "identifies" FTN. 

Good idea.  I've put it first to match the FrameTree constructor, and because
Navigator is probably a more commonly used concept than RenderFrameHostManager.

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
File content/browser/frame_host/interstitial_page_impl.cc (right):

https://codereview.chromium.org/72233002/diff/30001/content/browser/frame_hos...
content/browser/frame_host/interstitial_page_impl.cc:162: // TODO(creis): We
will also need to pass delegates for the RVHM as we
On 2013/11/14 08:23:38, nasko wrote:
> TODOs pile on ; )

They certainly do.  :)

[nasko, 2013-11-15 05:39:01]

lgtm

[commit-bot: I haz the power, 2013-11-15 05:51:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/72233002/180002

[commit-bot: I haz the power, 2013-11-15 08:27:55]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-15 08:50:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/72233002/180002

[commit-bot: I haz the power, 2013-11-15 09:54:08]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Charlie Reis, 2013-11-15 17:51:29]

Committed patchset #3 manually as r235365 (presubmit successful).