Cap SkVarAlloc's desired block at 64K.

Cap SkVarAlloc's desired block at 64K.

This means we can store fLgMinSize in 4 bits (TBD).

Local perf comparison calls this harmless-to-slightly-helpful.  Nothing to get
excited about, but seems to certainly not harm perf.


BUG=skia:

Committed: https://skia.googlesource.com/skia/+/975ae5e4b881d4df41fd06453a650d6312127c8d

[mtklein, 2014-11-13 20:56:27]

mtklein@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, schenney@chromium.org

[mtklein, 2014-11-13 20:58:52]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-13 20:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722293003/1

[commit-bot: I haz the power, 2014-11-13 20:59:08]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-14 02:59 UTC

[reed1, 2014-11-13 21:40:07]

https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp
File src/core/SkVarAlloc.cpp (right):

https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp#newc...
src/core/SkVarAlloc.cpp:48: if (fLgMinSize < 16) {
please add comment + possible a #define with a comment

https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.h
File src/core/SkVarAlloc.h (right):

https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.h#newcode31
src/core/SkVarAlloc.h:31: unsigned fLgMinSize;  // Can get away with 4 bits,
always in [4, 16].
not sure what the comment means

4 bits in 4..16 ?

[mtklein, 2014-11-13 21:44:40]

On 2014/11/13 21:40:07, reed1 wrote:
> https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp
> File src/core/SkVarAlloc.cpp (right):
> 
>
https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp#newc...
> src/core/SkVarAlloc.cpp:48: if (fLgMinSize < 16) {
> please add comment + possible a #define with a comment
> 
> https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.h
> File src/core/SkVarAlloc.h (right):
> 
>
https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.h#newcode31
> src/core/SkVarAlloc.h:31: unsigned fLgMinSize;  // Can get away with 4 bits,
> always in [4, 16].
> not sure what the comment means
> 
> 4 bits in 4..16 ?

PTAL.

[mtklein, 2014-11-13 21:46:36]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-11-13 21:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/722293003/20001

[commit-bot: I haz the power, 2014-11-13 21:47:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-14 03:47 UTC

[reed1, 2014-11-13 21:52:18]

danke, much clearer.
lgtm

[commit-bot: I haz the power, 2014-11-13 21:55:25]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/975ae5e4b881d4df41fd06453a650d6312127c8d