Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 722293003: Cap SkVarAlloc's desired block at 64K. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cap SkVarAlloc's desired block at 64K. This means we can store fLgMinSize in 4 bits (TBD). Local perf comparison calls this harmless-to-slightly-helpful. Nothing to get excited about, but seems to certainly not harm perf. BUG=skia: Committed: https://skia.googlesource.com/skia/+/975ae5e4b881d4df41fd06453a650d6312127c8d

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/core/SkVarAlloc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkVarAlloc.cpp View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mtklein
6 years, 1 month ago (2014-11-13 20:56:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722293003/1
6 years, 1 month ago (2014-11-13 20:59:02 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 20:59:08 UTC) #5
reed1
https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp File src/core/SkVarAlloc.cpp (right): https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp#newcode48 src/core/SkVarAlloc.cpp:48: if (fLgMinSize < 16) { please add comment + ...
6 years, 1 month ago (2014-11-13 21:40:07 UTC) #6
mtklein
On 2014/11/13 21:40:07, reed1 wrote: > https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp > File src/core/SkVarAlloc.cpp (right): > > https://codereview.chromium.org/722293003/diff/1/src/core/SkVarAlloc.cpp#newcode48 > ...
6 years, 1 month ago (2014-11-13 21:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722293003/20001
6 years, 1 month ago (2014-11-13 21:47:14 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 21:47:16 UTC) #10
reed1
danke, much clearer. lgtm
6 years, 1 month ago (2014-11-13 21:52:18 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 21:55:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/975ae5e4b881d4df41fd06453a650d6312127c8d

Powered by Google App Engine
This is Rietveld 408576698