runtime/vm/regexp.cc - Issue 722243002: Indirectly dispatch all backtracking jumps through the same block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp.cc

Issue 722243002: Indirectly dispatch all backtracking jumps through the same block. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: return on unreachable Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp.cc

diff --git a/runtime/vm/regexp.cc b/runtime/vm/regexp.cc

index 4e556dcbb747d93e908e6d7150192db747fde542..8a474a2b52ebc09b57f26cd61d245b7cf0229772 100644

--- a/runtime/vm/regexp.cc

+++ b/runtime/vm/regexp.cc

@@ -408,9 +408,9 @@ RegExpEngine::CompilationResult RegExpCompiler::Assemble(

}

if (reg_exp_too_big_) return IrregexpRegExpTooBig();

- macro_assembler->FinalizeIndirectGotos();

+ macro_assembler->GenerateBacktrackBlock();

- return RegExpEngine::CompilationResult(macro_assembler,

+ return RegExpEngine::CompilationResult(macro_assembler->backtrack_goto(),

macro_assembler->graph_entry(),

macro_assembler->num_blocks(),

macro_assembler->num_stack_locals());

« no previous file with comments | « runtime/vm/regexp.h ('k') | runtime/vm/regexp_assembler.h » ('j') | no next file with comments »