Extend typed lowering to cover JSStrictEqual on differing types.

Extend typed lowering to cover JSStrictEqual on differing types.

R=rossberg@chromium.org, titzer@chromium.org
TEST=unittests/JSTypedLoweringTest.JSStrictEqualWithTheHole

Committed: https://chromium.googlesource.com/v8/v8/+/a210f3684628e74cddf1f739a053946002418431

[rossberg, 2014-11-14 13:41:42]

rossberg@chromium.org changed reviewers:
+ rossberg@chromium.org

[rossberg, 2014-11-14 13:41:42]

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:495: Type* intersect =
Type::Intersect(r.left_type(), r.right_type(), zone());
That's what left_type->Maybe(right_type) is for. ;)

[titzer, 2014-11-14 13:43:24]

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:495: Type* intersect =
Type::Intersect(r.left_type(), r.right_type(), zone());
On 2014/11/14 13:41:42, rossberg wrote:
> That's what left_type->Maybe(right_type) is for. ;)

I like Maybe, I just want it to be reliable....
/unpopular_opinion_bird 
:(

[Michael Starzinger, 2014-11-14 14:03:06]

PTAL. Addressed comments and added unit test.

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/722223003/diff/1/src/compiler/js-typed-loweri...
src/compiler/js-typed-lowering.cc:495: Type* intersect =
Type::Intersect(r.left_type(), r.right_type(), zone());
On 2014/11/14 13:41:42, rossberg wrote:
> That's what left_type->Maybe(right_type) is for. ;)

Done.

[rossberg, 2014-11-14 14:06:22]

lgtm

[Michael Starzinger, 2014-11-14 14:25:26]

Committed patchset #2 (id:20001) manually as
a210f3684628e74cddf1f739a053946002418431 (presubmit successful).