Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 722173003: DevTools: Throttle Screencast on slow connections (Blink side) (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Throttle Screencast on slow connections (Blink side) BUG=397107 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185444

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M Source/devtools/front_end/screencast/ScreencastView.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
vkuzkokov
6 years, 1 month ago (2014-11-14 12:14:11 UTC) #2
dgozman
https://codereview.chromium.org/722173003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/722173003/diff/1/Source/devtools/protocol.json#newcode696 Source/devtools/protocol.json:696: { "name": "frameNumber", "type": "integer", "description": "Frame number."} Optional?
6 years, 1 month ago (2014-11-14 13:43:30 UTC) #3
vkuzkokov
https://codereview.chromium.org/722173003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/722173003/diff/1/Source/devtools/protocol.json#newcode696 Source/devtools/protocol.json:696: { "name": "frameNumber", "type": "integer", "description": "Frame number."} On ...
6 years, 1 month ago (2014-11-14 14:45:08 UTC) #4
dgozman
lgtm
6 years, 1 month ago (2014-11-14 16:49:41 UTC) #5
vkuzkokov
Pavel, PTAL: Source/devtools/protocol.json
6 years, 1 month ago (2014-11-14 17:16:43 UTC) #7
pfeldman
lgtm
6 years, 1 month ago (2014-11-17 13:29:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722173003/20001
6 years, 1 month ago (2014-11-17 13:31:46 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-17 14:36:24 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 185444

Powered by Google App Engine
This is Rietveld 408576698