Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: Source/devtools/protocol.json

Issue 722173002: [DevTools] Make unused ScreencastFrameMetadata properties optional (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index be75e96c83b0001afbe507a950ffad5e256d16f8..e63f466aef354bd6adae3e41d68294f1b48910ff 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -209,13 +209,13 @@
"type": "object",
"description": "Screencast frame metadata",
"properties": [
- { "name": "deviceScaleFactor", "type": "number", "hidden": true, "description": "Device scale factor." },
- { "name": "viewport", "$ref": "DOM.Rect", "hidden": true, "description": "Viewport in CSS pixels." },
- { "name": "offsetTop", "type": "number", "hidden": true, "optional": true, "description": "Top offset in DIP." },
+ { "name": "deviceScaleFactor", "type": "number", "hidden": true, "optional": true, "description": "Device scale factor." },
+ { "name": "viewport", "$ref": "DOM.Rect", "hidden": true, "optional": true, "description": "Viewport in CSS pixels." },
+ { "name": "offsetTop", "type": "number", "hidden": true, "description": "Top offset in DIP." },
{ "name": "offsetBottom", "type": "number", "hidden": true, "optional": true, "description": "Bottom offset in DIP." },
{ "name": "pageScaleFactor", "type": "number", "hidden": true, "description": "Page scale factor." },
- { "name": "pageScaleFactorMin", "type": "number", "hidden": true, "description": "Page scale factor min." },
- { "name": "pageScaleFactorMax", "type": "number", "hidden": true, "description": "Page scale factor max." },
+ { "name": "pageScaleFactorMin", "type": "number", "hidden": true, "optional": true, "description": "Page scale factor min." },
+ { "name": "pageScaleFactorMax", "type": "number", "hidden": true, "optional": true, "description": "Page scale factor max." },
{ "name": "deviceWidth", "type": "number", "hidden": true, "description": "Device screen width in DIP." },
{ "name": "deviceHeight", "type": "number", "hidden": true, "description": "Device screen height in DIP." },
{ "name": "scrollOffsetX", "type": "number", "hidden": true, "description": "Position of horizontal scroll in CSS pixels." },
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698