Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 722153004: Disable GM:lcdtextprops on 565 (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
Reviewers:
jcgregorio, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Disable GM:lcdtextprops on 565 The new GM is failing on 565/pipe. Disabling to get the tree green. R=reed@google.com,jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/f4905ccb6c987781d3c50cb23bfaad740182cd8a

Patch Set 1 #

Patch Set 2 : fixed onGetFlags signature #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gm/lcdtext.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722153004/1
6 years, 1 month ago (2014-11-13 19:14:53 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 19:14:54 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/626)
6 years, 1 month ago (2014-11-13 19:17:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/722153004/20001
6 years, 1 month ago (2014-11-13 19:20:24 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-13 19:20:25 UTC) #8
jcgregorio
lgtm
6 years, 1 month ago (2014-11-13 19:23:08 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 19:29:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f4905ccb6c987781d3c50cb23bfaad740182cd8a

Powered by Google App Engine
This is Rietveld 408576698